Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2331033003: DBC: A couple allocation fastpaths. (Closed)

Created:
4 years, 3 months ago by zra
Modified:
4 years, 3 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Try without AllocateT fastpath #

Patch Set 3 : Remove fastpath from unopt #

Patch Set 4 : Remove bad assert #

Patch Set 5 : Comments #

Total comments: 4

Patch Set 6 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -17 lines) Patch
M runtime/vm/constants_dbc.h View 1 2 3 4 3 chunks +17 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language_dbc.cc View 1 2 3 4 5 3 chunks +53 lines, -12 lines 0 comments Download
M runtime/vm/simulator_dbc.cc View 1 2 3 4 4 chunks +52 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
zra
4 years, 3 months ago (2016-09-13 15:01:24 UTC) #3
Florian Schneider
lgtm https://codereview.chromium.org/2331033003/diff/80001/runtime/vm/intermediate_language_dbc.cc File runtime/vm/intermediate_language_dbc.cc (right): https://codereview.chromium.org/2331033003/diff/80001/runtime/vm/intermediate_language_dbc.cc#newcode687 runtime/vm/intermediate_language_dbc.cc:687: const Register typ = locs()->in(kElementTypePos).reg(); s/typ/type_argument/ https://codereview.chromium.org/2331033003/diff/80001/runtime/vm/intermediate_language_dbc.cc#newcode1452 runtime/vm/intermediate_language_dbc.cc:1452: ...
4 years, 3 months ago (2016-09-13 17:06:58 UTC) #4
zra
https://codereview.chromium.org/2331033003/diff/80001/runtime/vm/intermediate_language_dbc.cc File runtime/vm/intermediate_language_dbc.cc (right): https://codereview.chromium.org/2331033003/diff/80001/runtime/vm/intermediate_language_dbc.cc#newcode687 runtime/vm/intermediate_language_dbc.cc:687: const Register typ = locs()->in(kElementTypePos).reg(); On 2016/09/13 17:06:58, Florian ...
4 years, 3 months ago (2016-09-13 17:21:18 UTC) #5
zra
4 years, 3 months ago (2016-09-13 17:21:31 UTC) #7
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) manually as
7d01ca5e0d496a8fc9243c0721edd5de6b5d28a5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698