Issue 233103003: [GCM] Adding basic G-services handling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 233103003: [GCM] Adding basic G-services handling (Closed)

Created:
6 years, 8 months ago by fgorski

Modified:
6 years, 8 months ago

Reviewers:
Nicolas Zea, jianli

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Adding basic G-services handling * extracting CheckinRequest::RequestInfo to better manage checkin parameters * adding G-services settings digest to RequestInfo of the checkin (will be sent with checkin request) * extracting G-services settings from checkin response * storing and loading of the G-services settings in GCM Store This patch relands https://codereview.chromium.org/215363007/ after all of the trybots, buildbots and CQ have been updated to run gcm_unit_tests TBR=zea@chromium.org,jianli@chromium.org BUG=359254 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263079

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+298 lines, -79 lines)			Patch
M	google_apis/gcm/engine/checkin_request.h	View	3 chunks	+30 lines, -15 lines	0 comments	Download
M	google_apis/gcm/engine/checkin_request.cc	View	4 chunks	+27 lines, -15 lines	0 comments	Download
M	google_apis/gcm/engine/checkin_request_unittest.cc	View	7 chunks	+23 lines, -14 lines	0 comments	Download
M	google_apis/gcm/engine/gcm_store.h	View	2 chunks	+10 lines, -0 lines	0 comments	Download
M	google_apis/gcm/engine/gcm_store_impl.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	google_apis/gcm/engine/gcm_store_impl.cc	View	9 chunks	+107 lines, -1 line	0 comments	Download
M	google_apis/gcm/engine/gcm_store_impl_unittest.cc	View	2 chunks	+49 lines, -1 line	0 comments	Download
M	google_apis/gcm/gcm_client_impl.h	View	2 chunks	+7 lines, -8 lines	0 comments	Download
M	google_apis/gcm/gcm_client_impl.cc	View	2 chunks	+19 lines, -14 lines	0 comments	Download
M	google_apis/gcm/tools/mcs_probe.cc	View	2 chunks	+20 lines, -11 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fgorski@chromium.org/233103003/1

6 years, 8 months ago (2014-04-10 18:46:10 UTC) #3

Message was sent while issue was closed.

Change committed as 263079

Expand Messages | Collapse Messages