Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 233103002: Added a call to hide the popup when the render process dies. (Closed)

Created:
6 years, 8 months ago by elisabets
Modified:
6 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add a call to hide the popup when the render process dies. Prevent persistent popups after the render process has died, also resetting scroll accounting and gesture detection. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263613

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated code with added calls to |resetScrollInProgress()| and |resetGestureDetectors()| #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
elisabets
6 years, 8 months ago (2014-04-10 12:28:59 UTC) #1
jdduke (slow)
https://codereview.chromium.org/233103002/diff/1/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java File content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java (right): https://codereview.chromium.org/233103002/diff/1/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java#newcode740 content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:740: hidePopupDialog(); If the ContentViewCore persists (permanently) after the renderer ...
6 years, 8 months ago (2014-04-10 14:02:04 UTC) #2
jdduke (slow)
tedchoc@: After renderProcessGone(), the ContentViewCore may be re-used? Or no?
6 years, 8 months ago (2014-04-10 20:56:28 UTC) #3
Ted C
On 2014/04/10 20:56:28, jdduke wrote: > tedchoc@: After renderProcessGone(), the ContentViewCore may be re-used? Or ...
6 years, 8 months ago (2014-04-10 22:18:33 UTC) #4
jdduke (slow)
https://codereview.chromium.org/233103002/diff/1/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java File content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java (right): https://codereview.chromium.org/233103002/diff/1/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java#newcode740 content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:740: hidePopupDialog(); On 2014/04/10 14:02:04, jdduke wrote: > If the ...
6 years, 8 months ago (2014-04-11 00:11:00 UTC) #5
jdduke (slow)
lgtm, but please update "BUG=#" if there is an existing bug/issue associated with this problem, ...
6 years, 8 months ago (2014-04-11 14:57:03 UTC) #6
elisabets
On 2014/04/11 14:57:03, jdduke wrote: > lgtm, but please update "BUG=#" if there is an ...
6 years, 8 months ago (2014-04-14 06:00:08 UTC) #7
elisabets
The CQ bit was checked by elisabets@opera.com
6 years, 8 months ago (2014-04-14 07:48:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/elisabets@opera.com/233103002/20001
6 years, 8 months ago (2014-04-14 07:48:37 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-04-14 12:25:04 UTC) #10
Message was sent while issue was closed.
Change committed as 263613

Powered by Google App Engine
This is Rietveld 408576698