Added a call to hide the popup when the render process dies.

Add a call to hide the popup when the render process dies.

Prevent persistent popups after the render process has died, also resetting
scroll accounting and gesture detection.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263613

[jdduke (slow), 2014-04-10 14:02:04]

https://codereview.chromium.org/233103002/diff/1/content/public/android/java/...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
(right):

https://codereview.chromium.org/233103002/diff/1/content/public/android/java/...
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:740:
hidePopupDialog();
If the ContentViewCore persists (permanently) after the renderer is destroyed,
we'll want to also call |resetScrollInProgress()| and |resetGestureDetectors()|.
 I'm not exactly sure what the relative lifetimes are...

[jdduke (slow), 2014-04-10 20:56:28]

tedchoc@:  After renderProcessGone(), the ContentViewCore may be re-used? Or no?

[Ted C, 2014-04-10 22:18:33]

On 2014/04/10 20:56:28, jdduke wrote:
> tedchoc@:  After renderProcessGone(), the ContentViewCore may be re-used? Or
no?

It definitely can outlive a renderer's lifetime.  You can test by just doing
"adb shell kill [PID]" for the renderer process.  The tab will show the sad tab,
but the webcontents and contentviewcore will stick around.

[jdduke (slow), 2014-04-11 00:11:00]

https://codereview.chromium.org/233103002/diff/1/content/public/android/java/...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
(right):

https://codereview.chromium.org/233103002/diff/1/content/public/android/java/...
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:740:
hidePopupDialog();
On 2014/04/10 14:02:04, jdduke wrote:
> If the ContentViewCore persists (permanently) after the renderer is destroyed,
> we'll want to also call |resetScrollInProgress()| and
|resetGestureDetectors()|.
>  I'm not exactly sure what the relative lifetimes are...

Yeah, turns out we'll want to call both of the mentioned methods, good catch.

[jdduke (slow), 2014-04-11 14:57:03]

lgtm, but please update "BUG=#" if there is an existing bug/issue associated
with this problem, thanks.

[elisabets, 2014-04-14 06:00:08]

On 2014/04/11 14:57:03, jdduke wrote:
> lgtm, but please update "BUG=#" if there is an existing bug/issue associated
> with this problem, thanks.

I could not find any reported bug for chrome... If anyone recalls seeing one,
please let me know!

[elisabets, 2014-04-14 07:48:24]

The CQ bit was checked by elisabets@opera.com

[commit-bot: I haz the power, 2014-04-14 07:48:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/elisabets@opera.com/233103002/20001

[commit-bot: I haz the power, 2014-04-14 12:25:04]

Change committed as 263613