Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Side by Side Diff: net/url_request/url_request_http_job_unittest.cc

Issue 2330983002: Removes get upload progress plumbing. URLRequest queries the UploadDataStream directly. (Closed)
Patch Set: Rebased till refs/heads/master@{#417939} Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/url_request/url_request_http_job.h" 5 #include "net/url_request/url_request_http_job.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include <cstddef> 9 #include <cstddef>
10 #include <memory> 10 #include <memory>
(...skipping 888 matching lines...) Expand 10 before | Expand all | Expand 10 after
899 ADD_FAILURE(); 899 ADD_FAILURE();
900 return ERR_NOT_IMPLEMENTED; 900 return ERR_NOT_IMPLEMENTED;
901 } 901 }
902 902
903 void Drain(HttpNetworkSession* session) override {} 903 void Drain(HttpNetworkSession* session) override {}
904 904
905 void PopulateNetErrorDetails(NetErrorDetails* details) override { return; } 905 void PopulateNetErrorDetails(NetErrorDetails* details) override { return; }
906 906
907 void SetPriority(RequestPriority priority) override {} 907 void SetPriority(RequestPriority priority) override {}
908 908
909 UploadProgress GetUploadProgress() const override {
910 return UploadProgress();
911 }
912
913 HttpStream* RenewStreamForAuth() override { return nullptr; } 909 HttpStream* RenewStreamForAuth() override { return nullptr; }
914 910
915 // Fake implementation of WebSocketHandshakeStreamBase method(s) 911 // Fake implementation of WebSocketHandshakeStreamBase method(s)
916 std::unique_ptr<WebSocketStream> Upgrade() override { 912 std::unique_ptr<WebSocketStream> Upgrade() override {
917 return std::unique_ptr<WebSocketStream>(); 913 return std::unique_ptr<WebSocketStream>();
918 } 914 }
919 915
920 private: 916 private:
921 bool initialize_stream_was_called_; 917 bool initialize_stream_was_called_;
922 }; 918 };
(...skipping 21 matching lines...) Expand all
944 base::RunLoop().RunUntilIdle(); 940 base::RunLoop().RunUntilIdle();
945 EXPECT_EQ(URLRequestStatus::IO_PENDING, req_->status().status()); 941 EXPECT_EQ(URLRequestStatus::IO_PENDING, req_->status().status());
946 EXPECT_TRUE(fake_handshake_stream->initialize_stream_was_called()); 942 EXPECT_TRUE(fake_handshake_stream->initialize_stream_was_called());
947 } 943 }
948 944
949 #endif // defined(ENABLE_WEBSOCKETS) 945 #endif // defined(ENABLE_WEBSOCKETS)
950 946
951 } // namespace 947 } // namespace
952 948
953 } // namespace net 949 } // namespace net
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698