Removes get upload progress plumbing. URLRequest queries the UploadDataStream directly.

Removes the plumbing to get upload progress since URLRequest owns the
upload data stream and it can directly ask the stream for the progress instead of
going to URLRequestJob, HttpTransaction and HttpStream layers.

BUG=472740
Committed: https://crrev.com/b9a14395aa00b3114aa35485dfd5190190a8e79f
Cr-Commit-Position: refs/heads/master@{#419492}

[shivanisha, 2016-09-12 13:31:27]

The CQ bit was checked by shivanisha@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-12 13:31:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 13:33:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 13:33:49]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[shivanisha, 2016-09-12 15:44:52]

The CQ bit was checked by shivanisha@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-12 15:45:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 16:59:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 16:59:14]

Dry run: This issue passed the CQ dry run.

[shivanisha, 2016-09-12 18:09:37]

shivanisha@chromium.org changed reviewers:
+ mmenke@chromium.org

[shivanisha, 2016-09-12 18:11:32]

As per feedback, this CL extracts the upload progress plumbing removal out of CL
2298823002.

[shivanisha, 2016-09-12 18:13:30]

Patchset #2 (id:20001) has been deleted

[mmenke, 2016-09-12 19:35:31]

https://codereview.chromium.org/2330983002/diff/40001/net/base/upload_data_st...
File net/base/upload_data_stream.cc (right):

https://codereview.chromium.org/2330983002/diff/40001/net/base/upload_data_st...
net/base/upload_data_stream.cc:195: }
nit:  Remove braces.

https://codereview.chromium.org/2330983002/diff/40001/net/base/upload_data_st...
File net/base/upload_data_stream.h (right):

https://codereview.chromium.org/2330983002/diff/40001/net/base/upload_data_st...
net/base/upload_data_stream.h:95: // succesfully, it returns empty
UploadProgress.
Maybe replace the second sentence with "If the stream was not initialized
successfully, or has been reset and not yet re-initialized, returns an empty
UploadProgress."

https://codereview.chromium.org/2330983002/diff/40001/net/base/upload_data_st...
net/base/upload_data_stream.h:95: // succesfully, it returns empty
UploadProgress.
Rather unexciting, but we should probably have a test for the new behaviors -
check value after Initialized() called, when it returns ERR_IO_PENDING, and
check value after Reset() is called.  May even want to do both twice, in a loop
(With a successful initialization and a check that it's true in between)

https://codereview.chromium.org/2330983002/diff/40001/net/url_request/url_req...
File net/url_request/url_request.cc (right):

https://codereview.chromium.org/2330983002/diff/40001/net/url_request/url_req...
net/url_request/url_request.cc:367: }
nit:  Don't use braces on single-line if.

[shivanisha, 2016-09-14 19:39:51]

The CQ bit was checked by shivanisha@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 19:40:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[shivanisha, 2016-09-14 20:40:26]

https://codereview.chromium.org/2330983002/diff/40001/net/base/upload_data_st...
File net/base/upload_data_stream.cc (right):

https://codereview.chromium.org/2330983002/diff/40001/net/base/upload_data_st...
net/base/upload_data_stream.cc:195: }
On 2016/09/12 at 19:35:31, mmenke wrote:
> nit:  Remove braces.

done.

https://codereview.chromium.org/2330983002/diff/40001/net/base/upload_data_st...
File net/base/upload_data_stream.h (right):

https://codereview.chromium.org/2330983002/diff/40001/net/base/upload_data_st...
net/base/upload_data_stream.h:95: // succesfully, it returns empty
UploadProgress.
On 2016/09/12 at 19:35:31, mmenke wrote:
> Rather unexciting, but we should probably have a test for the new behaviors -
check value after Initialized() called, when it returns ERR_IO_PENDING, and
check value after Reset() is called.  May even want to do both twice, in a loop
(With a successful initialization and a check that it's true in between)

Updated the comment.
Added tests in http_stream_parser_unittest.cc

https://codereview.chromium.org/2330983002/diff/40001/net/url_request/url_req...
File net/url_request/url_request.cc (right):

https://codereview.chromium.org/2330983002/diff/40001/net/url_request/url_req...
net/url_request/url_request.cc:367: }
On 2016/09/12 at 19:35:31, mmenke wrote:
> nit:  Don't use braces on single-line if.

done.

[commit-bot: I haz the power, 2016-09-14 20:54:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 20:54:44]

Dry run: This issue passed the CQ dry run.

[mmenke, 2016-09-15 15:15:53]

LGTM

https://codereview.chromium.org/2330983002/diff/60001/net/http/http_stream_pa...
File net/http/http_stream_parser_unittest.cc (right):

https://codereview.chromium.org/2330983002/diff/60001/net/http/http_stream_pa...
net/http/http_stream_parser_unittest.cc:125: // test upload progress after init.
nit:  capitalize Test (x2)

[shivanisha, 2016-09-16 14:23:00]

shivanisha@chromium.org changed reviewers:
+ dgozman@chromium.org

[shivanisha, 2016-09-16 14:25:09]

dgozman@, PTAL for devtools_network_transaction*. Thanks!

[dgozman, 2016-09-16 16:41:28]

devtools lgtm

[shivanisha, 2016-09-19 15:17:30]

The CQ bit was checked by shivanisha@chromium.org

[shivanisha, 2016-09-19 15:17:31]

The patchset sent to the CQ was uploaded after l-g-t-m from mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/2330983002/#ps80001
(title: "Feedback incorporated.")

[commit-bot: I haz the power, 2016-09-19 15:17:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 17:24:03]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-09-19 17:26:05]

Description was changed from

==========
Removes the plumbing to get upload progress since URLRequest owns the
upload data stream and it can directly ask the stream for the progress instead
of
going to URLRequestJob, HttpTransaction and HttpStream layers.

BUG=472740
==========

to

==========
Removes the plumbing to get upload progress since URLRequest owns the
upload data stream and it can directly ask the stream for the progress instead
of
going to URLRequestJob, HttpTransaction and HttpStream layers.

BUG=472740

Committed: https://crrev.com/b9a14395aa00b3114aa35485dfd5190190a8e79f
Cr-Commit-Position: refs/heads/master@{#419492}
==========

[commit-bot: I haz the power, 2016-09-19 17:26:07]

Patchset 4 (id:??) landed as
https://crrev.com/b9a14395aa00b3114aa35485dfd5190190a8e79f
Cr-Commit-Position: refs/heads/master@{#419492}