Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(956)

Issue 2330963002: Audit the use of updateStyleAndLayoutIgnorePendingStylesheets in VisiblePositionTemplate::create (Closed)

Created:
4 years, 3 months ago by Xiaocheng
Modified:
4 years, 3 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Audit the use of updateStyleAndLayoutIgnorePendingStylesheets in VisiblePositionTemplate::create BUG=590369 Committed: https://crrev.com/c2e0a2bd01fe69bbe724fe5608004ce0afaee49d Cr-Commit-Position: refs/heads/master@{#418144}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -5 lines) Patch
M third_party/WebKit/Source/core/editing/VisiblePosition.cpp View 4 chunks +39 lines, -5 lines 1 comment Download

Messages

Total messages: 12 (7 generated)
Xiaocheng
PTAL.
4 years, 3 months ago (2016-09-13 02:00:15 UTC) #6
yosin_UTC9
lgtm https://codereview.chromium.org/2330963002/diff/1/third_party/WebKit/Source/core/editing/VisiblePosition.cpp File third_party/WebKit/Source/core/editing/VisiblePosition.cpp (right): https://codereview.chromium.org/2330963002/diff/1/third_party/WebKit/Source/core/editing/VisiblePosition.cpp#newcode65 third_party/WebKit/Source/core/editing/VisiblePosition.cpp:65: DCHECK(!document.needsLayoutTreeUpdate()); Good job! I've never thought we can ...
4 years, 3 months ago (2016-09-13 02:25:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2330963002/1
4 years, 3 months ago (2016-09-13 02:25:52 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-13 02:29:56 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 02:32:01 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c2e0a2bd01fe69bbe724fe5608004ce0afaee49d
Cr-Commit-Position: refs/heads/master@{#418144}

Powered by Google App Engine
This is Rietveld 408576698