third_party/WebKit/Source/modules/sensor/Sensor.h - Issue 2330943002: [Sensors] Handle default sensor configuration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/sensor/Sensor.h

Issue 2330943002: [Sensors] Handle default sensor configuration (Closed)

Patch Set: Rebased Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/sensor/Sensor.h

diff --git a/third_party/WebKit/Source/modules/sensor/Sensor.h b/third_party/WebKit/Source/modules/sensor/Sensor.h

index 94ca5ae314638a03c95fd7d86d48a4f60ee0a8e6..cb7cb8be2e459a6c4daa5b3742d6988b7c93f238 100644

--- a/third_party/WebKit/Source/modules/sensor/Sensor.h

+++ b/third_party/WebKit/Source/modules/sensor/Sensor.h

@@ -68,7 +68,8 @@ protected:

virtual SensorReading* createSensorReading(SensorProxy*) = 0;

using SensorConfigurationPtr = device::mojom::blink::SensorConfigurationPtr;

- virtual SensorConfigurationPtr createSensorConfig(const SensorOptions&) = 0;

+ using SensorConfiguration = device::mojom::blink::SensorConfiguration;

+ virtual SensorConfigurationPtr createSensorConfig(const SensorOptions&, const SensorConfiguration& defaultConfiguration) = 0;

private:

void initSensorProxyIfNeeded();