Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 233093006: Stop disabling force_compositing_mode for background RenderViews. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: background: test Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_content_browser_client.cc
diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
index 843da93fd5eb1ce95de38e064441be8f64c0d8d1..eabcae5fa30ff93e35a231e7f9f5a4fa8fc57259 100644
--- a/chrome/browser/chrome_content_browser_client.cc
+++ b/chrome/browser/chrome_content_browser_client.cc
@@ -2233,6 +2233,18 @@ bool ChromeContentBrowserClient::IsFastShutdownPossible() {
return true;
}
+bool ChromeContentBrowserClient::IsRenderViewHostForBackground(
+ RenderViewHost* rvh) {
+ WebContents* web_contents = WebContents::FromRenderViewHost(rvh);
+ extensions::ViewType view_type = extensions::GetViewType(web_contents);
+ bool background =
+ view_type == extensions::VIEW_TYPE_BACKGROUND_CONTENTS ||
+ view_type == extensions::VIEW_TYPE_EXTENSION_BACKGROUND_PAGE;
+ if (background)
+ LOG(ERROR) << "DISABLING FORCE COMPOSITING MODE";
+ return background;
+}
+
void ChromeContentBrowserClient::OverrideWebkitPrefs(
RenderViewHost* rvh, const GURL& url, WebPreferences* web_prefs) {
Profile* profile = Profile::FromBrowserContext(
@@ -2363,11 +2375,6 @@ void ChromeContentBrowserClient::OverrideWebkitPrefs(
if (view_type == extensions::VIEW_TYPE_NOTIFICATION) {
web_prefs->allow_scripts_to_close_windows = true;
- } else if (view_type == extensions::VIEW_TYPE_BACKGROUND_CONTENTS) {
- // Disable all kinds of acceleration for background pages.
- // See http://crbug.com/96005 and http://crbug.com/96006
- web_prefs->force_compositing_mode = false;
- web_prefs->accelerated_compositing_enabled = false;
}
#if defined(OS_CHROMEOS)

Powered by Google App Engine
This is Rietveld 408576698