Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Side by Side Diff: chrome/browser/extensions/extension_webkit_preferences.cc

Issue 233093006: Stop disabling force_compositing_mode for background RenderViews. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: background: codemoved Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/extension_webkit_preferences.h" 5 #include "chrome/browser/extensions/extension_webkit_preferences.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "chrome/common/chrome_switches.h" 8 #include "chrome/common/chrome_switches.h"
9 #include "extensions/common/extension.h" 9 #include "extensions/common/extension.h"
10 #include "extensions/common/manifest.h" 10 #include "extensions/common/manifest.h"
11 #include "webkit/common/webpreferences.h" 11 #include "webkit/common/webpreferences.h"
12 12
13 namespace extension_webkit_preferences { 13 namespace extension_webkit_preferences {
14 14
15 void SetPreferences(const extensions::Extension* extension, 15 void SetPreferences(const extensions::Extension* extension,
16 extensions::ViewType render_view_type, 16 extensions::ViewType render_view_type,
17 WebPreferences* webkit_prefs) { 17 WebPreferences* webkit_prefs) {
18 if (!extension) 18 if (!extension)
19 return; 19 return;
20 20
21 if (!extension->is_hosted_app()) { 21 if (!extension->is_hosted_app()) {
22 // Extensions are trusted so we override any user preferences for disabling 22 // Extensions are trusted so we override any user preferences for disabling
23 // javascript or images. 23 // javascript or images.
24 webkit_prefs->loads_images_automatically = true; 24 webkit_prefs->loads_images_automatically = true;
25 webkit_prefs->javascript_enabled = true; 25 webkit_prefs->javascript_enabled = true;
26 26
27 // Tabs aren't typically allowed to close windows. But extensions shouldn't 27 // Tabs aren't typically allowed to close windows. But extensions shouldn't
28 // be subject to that. 28 // be subject to that.
29 webkit_prefs->allow_scripts_to_close_windows = true; 29 webkit_prefs->allow_scripts_to_close_windows = true;
30
31 // Disable gpu acceleration for extension background pages to avoid
32 // unecessarily creating a compositor context for them.
33 if (render_view_type == extensions::VIEW_TYPE_EXTENSION_BACKGROUND_PAGE) {
34 webkit_prefs->accelerated_compositing_enabled = false;
35 webkit_prefs->force_compositing_mode = false;
36 }
37 } 30 }
38 31
39 if (extension->is_platform_app()) { 32 if (extension->is_platform_app()) {
40 webkit_prefs->databases_enabled = false; 33 webkit_prefs->databases_enabled = false;
41 webkit_prefs->local_storage_enabled = false; 34 webkit_prefs->local_storage_enabled = false;
42 webkit_prefs->sync_xhr_in_documents_enabled = false; 35 webkit_prefs->sync_xhr_in_documents_enabled = false;
43 webkit_prefs->cookie_enabled = false; 36 webkit_prefs->cookie_enabled = false;
44 } 37 }
45 38
46 // Enable WebGL features that regular pages can't access, since they add 39 // Enable WebGL features that regular pages can't access, since they add
47 // more risk of fingerprinting. 40 // more risk of fingerprinting.
48 webkit_prefs->privileged_webgl_extensions_enabled = true; 41 webkit_prefs->privileged_webgl_extensions_enabled = true;
49 } 42 }
50 43
51 } // namespace extension_webkit_preferences 44 } // namespace extension_webkit_preferences
OLDNEW
« no previous file with comments | « chrome/browser/chrome_content_browser_client.cc ('k') | chrome/browser/extensions/gpu_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698