Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 233093003: Fix GPU-less build. (Closed)

Created:
6 years, 8 months ago by scroggo
Modified:
6 years, 8 months ago
Reviewers:
egdaniel
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Fix GPU-less build. Do not include GrTBackendEffectFactory.h if SK_SUPPORT_GPU is undefined. TBR=egdaniel@google.com NOTREECHECKS=true NOTRY=true Committed: http://code.google.com/p/skia/source/detail?r=14134

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/effects/gradients/SkTwoPointConicalGradient_gpu.cpp View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 5 (0 generated)
scroggo
The CQ bit was checked by scroggo@google.com
6 years, 8 months ago (2014-04-10 16:02:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/233093003/1
6 years, 8 months ago (2014-04-10 16:02:53 UTC) #2
commit-bot: I haz the power
Change committed as 14134
6 years, 8 months ago (2014-04-10 16:03:10 UTC) #3
scroggo
https://codereview.chromium.org/233093003/diff/1/src/effects/gradients/SkTwoPointConicalGradient_gpu.cpp File src/effects/gradients/SkTwoPointConicalGradient_gpu.cpp (left): https://codereview.chromium.org/233093003/diff/1/src/effects/gradients/SkTwoPointConicalGradient_gpu.cpp#oldcode9 src/effects/gradients/SkTwoPointConicalGradient_gpu.cpp:9: #include "GrTBackendEffectFactory.h" Why doesn't this file exist in GPU-less ...
6 years, 8 months ago (2014-04-10 16:03:19 UTC) #4
egdaniel
6 years, 8 months ago (2014-04-10 16:14:20 UTC) #5
Message was sent while issue was closed.
https://codereview.chromium.org/233093003/diff/1/src/effects/gradients/SkTwoP...
File src/effects/gradients/SkTwoPointConicalGradient_gpu.cpp (left):

https://codereview.chromium.org/233093003/diff/1/src/effects/gradients/SkTwoP...
src/effects/gradients/SkTwoPointConicalGradient_gpu.cpp:9: #include
"GrTBackendEffectFactory.h"
Ah that's right. If the gpu is not supported we don't include anything in
include/gpu (which was the reason for the guard in the first place)

On 2014/04/10 16:03:19, scroggo wrote:
> Why doesn't this file exist in GPU-less build?
> 
> Either way, I have tested this change and it builds without SK_SUPPORT_GPU.

Powered by Google App Engine
This is Rietveld 408576698