Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.h

Issue 2330863003: Switch to null root property tree nodes [spv2] (Closed)
Patch Set: Rebase from space Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/ObjectPaintProperties.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/FrameView.h
diff --git a/third_party/WebKit/Source/core/frame/FrameView.h b/third_party/WebKit/Source/core/frame/FrameView.h
index 464953ad0d065036ef9cc5aaa9a588a63fabdee8..8278f9c87aeb724eba9c42c5fe9951a3f89adf41 100644
--- a/third_party/WebKit/Source/core/frame/FrameView.h
+++ b/third_party/WebKit/Source/core/frame/FrameView.h
@@ -41,7 +41,6 @@
#include "platform/geometry/LayoutRect.h"
#include "platform/graphics/Color.h"
#include "platform/graphics/paint/ClipPaintPropertyNode.h"
-#include "platform/graphics/paint/EffectPaintPropertyNode.h"
#include "platform/graphics/paint/ScrollPaintPropertyNode.h"
#include "platform/graphics/paint/TransformPaintPropertyNode.h"
#include "platform/scroll/ScrollTypes.h"
@@ -607,17 +606,6 @@ public:
void setContentClip(PassRefPtr<ClipPaintPropertyNode> contentClip) { m_contentClip = contentClip; }
ClipPaintPropertyNode* contentClip() const { return m_contentClip.get(); }
- // We store no-op paint property tree nodes at the root of the tree.
- // TODO(pdr): Remove this concept in favor of null nodes, see: crbug.com/645615
- void setRootTransform(PassRefPtr<TransformPaintPropertyNode> rootTransform) { m_rootTransform = rootTransform; }
- TransformPaintPropertyNode* rootTransform() const { return m_rootTransform.get(); }
- void setRootClip(PassRefPtr<ClipPaintPropertyNode> rootClip) { m_rootClip = rootClip; }
- ClipPaintPropertyNode* rootClip() const { return m_rootClip.get(); }
- void setRootEffect(PassRefPtr<EffectPaintPropertyNode> rootEffect) { m_rootEffect = rootEffect; }
- EffectPaintPropertyNode* rootEffect() const { return m_rootEffect.get(); }
- void setRootScroll(PassRefPtr<ScrollPaintPropertyNode> rootScroll) { m_rootScroll = rootScroll; }
- ScrollPaintPropertyNode* rootScroll() const { return m_rootScroll.get(); }
-
// TODO(ojan): Merge this with IntersectionObserver once it lands.
IntRect computeVisibleArea();
@@ -929,13 +917,6 @@ private:
// TODO(trchen): This will not be needed once settings->rootLayerScrolls() is enabled.
RefPtr<ClipPaintPropertyNode> m_contentClip;
- // These nodes represent the root nodes of each property tree.
- // Only the root frame should create them and they will be no-op.
- RefPtr<TransformPaintPropertyNode> m_rootTransform;
- RefPtr<ClipPaintPropertyNode> m_rootClip;
- RefPtr<EffectPaintPropertyNode> m_rootEffect;
- RefPtr<ScrollPaintPropertyNode> m_rootScroll;
-
// This is set on the local root frame view only.
DocumentLifecycle::LifecycleState m_currentUpdateLifecyclePhasesTargetState;
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/ObjectPaintProperties.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698