Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(799)

Issue 2330843002: Blink-in-JS should not run micro tasks (Closed)

Created:
1 year, 3 months ago by haraken
Modified:
1 year, 3 months ago
Reviewers:
Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Blink-in-JS should not run micro tasks If Blink-in-JS runs micro tasks, there's a risk of causing a UXSS bug (see 645211 for concrete steps). This CL makes Blink-in-JS use callInternalFunction (instead of callFunction) to avoid running micro tasks after Blink-in-JS' callbacks. BUG=645211 Committed: https://crrev.com/0a242b6c8a66ee530d5b68c74dfabe74e6415d45 Cr-Commit-Position: refs/heads/master@{#417874}

Patch Set 1 #

Patch Set 2 : temp #

Messages

Total messages: 16 (11 generated)
haraken
PTAL
1 year, 3 months ago (2016-09-12 00:56:07 UTC) #4
Yuki
lgtm
1 year, 3 months ago (2016-09-12 05:55:36 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2330843002/20001
1 year, 3 months ago (2016-09-12 05:58:54 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
1 year, 3 months ago (2016-09-12 06:02:28 UTC) #14
commit-bot: I haz the power
1 year, 3 months ago (2016-09-12 06:04:31 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0a242b6c8a66ee530d5b68c74dfabe74e6415d45
Cr-Commit-Position: refs/heads/master@{#417874}

Powered by Google App Engine
This is Rietveld 0eb02b776