Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 2330833002: Revert a change which broke the "Open/Copy Link" context menu items on the Mac sad tab. (Closed)

Created:
4 years, 3 months ago by Sidney San Martín
Modified:
4 years, 3 months ago
Reviewers:
Nico
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert a change which broke the "Open/Copy Link" context menu items on the Mac sad tab. It turns out that these menu items require text to be selectable. A couple of possible fixes: - Make the selection color transparent. - Let the text be selected, but clear the selection when the context menu closes. Partially reverts https://codereview.chromium.org/2261793002. BUG=645820 Committed: https://crrev.com/7bb8e10b35b92413ca8c3d4830518089d0f42c70 Cr-Commit-Position: refs/heads/master@{#417865}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M chrome/browser/ui/cocoa/tab_contents/sad_tab_view_cocoa.mm View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Sidney San Martín
4 years, 3 months ago (2016-09-11 16:50:09 UTC) #2
Nico
On 2016/09/11 16:50:09, Sidney San Martín wrote: LGTM, but add a link to the cl ...
4 years, 3 months ago (2016-09-11 23:27:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2330833002/1
4 years, 3 months ago (2016-09-12 01:51:47 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-12 02:31:56 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 02:33:34 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7bb8e10b35b92413ca8c3d4830518089d0f42c70
Cr-Commit-Position: refs/heads/master@{#417865}

Powered by Google App Engine
This is Rietveld 408576698