Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2330813002: Reapply abc5051854fd7c98c7ba6b593211e47dcbcec9e8: Remove 'Element.docRange'. (Closed)

Created:
4 years, 3 months ago by scheglov
Modified:
4 years, 3 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reapply abc5051854fd7c98c7ba6b593211e47dcbcec9e8: Remove 'Element.docRange'. I also marked the corresponding information in summaries as @deprecated and made a small tweak to the generator so that it knows that the ids of deprecated fields are still used. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/663a3e810c8f441c5fa0ca6fa350a9e18aca56fe

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -244 lines) Patch
M pkg/analyzer/CHANGELOG.md View 1 chunk +3 lines, -0 lines 1 comment Download
M pkg/analyzer/lib/dart/element/element.dart View 1 chunk +0 lines, -9 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/element.dart View 11 chunks +0 lines, -114 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/handle.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/member.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/generated/utilities_dart.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/format.dart View 6 chunks +6 lines, -47 lines 0 comments Download
M pkg/analyzer/lib/src/summary/format.fbs View Binary file 0 comments Download
M pkg/analyzer/lib/src/summary/idl.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_ast.dart View 1 chunk +1 line, -4 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analyzer/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/all_the_rest_test.dart View 17 chunks +28 lines, -53 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analyzer/tool/summary/generate.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 3 months ago (2016-09-11 00:50:48 UTC) #1
Brian Wilkerson
lgtm https://codereview.chromium.org/2330813002/diff/1/pkg/analyzer/CHANGELOG.md File pkg/analyzer/CHANGELOG.md (right): https://codereview.chromium.org/2330813002/diff/1/pkg/analyzer/CHANGELOG.md#newcode2 pkg/analyzer/CHANGELOG.md:2: * Removed `Element.docRange`. No change requested, but I'll ...
4 years, 3 months ago (2016-09-11 15:38:23 UTC) #2
Paul Berry
lgtm
4 years, 3 months ago (2016-09-11 16:25:10 UTC) #3
scheglov
4 years, 3 months ago (2016-09-11 16:41:59 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
663a3e810c8f441c5fa0ca6fa350a9e18aca56fe (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698