Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 2330803002: Remove IncrementalScanner and IncrementalParser. (Closed)

Created:
4 years, 3 months ago by scheglov
Modified:
4 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove IncrementalScanner and IncrementalParser. This code has never been used AFAIK. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/f658a7de4225b8bf85d3acba067c1a0ce69e0d27

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2613 lines) Patch
D pkg/analyzer/lib/src/generated/incremental_scanner.dart View 1 chunk +0 lines, -251 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 3 chunks +0 lines, -1429 lines 0 comments Download
D pkg/analyzer/test/generated/incremental_scanner_test.dart View 1 chunk +0 lines, -548 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 3 chunks +0 lines, -383 lines 0 comments Download
M pkg/analyzer/test/generated/test_all.dart View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 3 months ago (2016-09-11 00:35:03 UTC) #1
Brian Wilkerson
lgtm
4 years, 3 months ago (2016-09-11 15:36:33 UTC) #2
scheglov
4 years, 3 months ago (2016-09-11 16:32:17 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f658a7de4225b8bf85d3acba067c1a0ce69e0d27 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698