[DevTools] Save as HAR: classify time before network activity as "blocked".

Source/devtools/front_end/HAREntry.js

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 31 matching lines @@
 {
     this._request = request;
 }
 
 WebInspector.HAREntry.prototype = {
     /**
      * @return {Object}
      */
     build: function()
     {
-        var entry =  {
+        var timings = this._buildTimings();
+        var time = Math.max(timings.blocked, 0) + Math.max(timings.dns, 0) + Math.max(timings.connect, 0) + Math.max(timings.send, 0) + Math.max(timings.wait, 0) + Math.max(timings.receive, 0);

[caseq, 2013/08/30 15:12:53]

So if we lost some time due to imperfect instrumentation, we will report
something different from whatever is show in the Network panel and different
from the wall time. I don't think that's right.

[eustas, 2013/09/13 15:10:36]

Done.

+
+        var entry = {
             startedDateTime: new Date(this._request.startTime * 1000),
-            time: WebInspector.HAREntry._toMilliseconds(this._request.duration),
+            time: time,
             request: this._buildRequest(),
             response: this._buildResponse(),
             cache: { }, // Not supported yet.
-            timings: this._buildTimings()
+            timings: timings
         };
+
         if (this._request.connectionId)
             entry.connection = String(this._request.connectionId);
         var page = WebInspector.networkLog.pageLoadForRequest(this._request);
         if (page)
             entry.pageref = "page_" + page.id;
         return entry;
     },
 
     /**
      * @return {Object}
@@ skipping 48 matching lines @@
         if (typeof compression === "number")
             content.compression = compression;
         return content;
     },
 
     /**
      * @return {Object}
      */
     _buildTimings: function()
     {
-        var waitForConnection = this._interval("connectStart", "connectEnd");
-        var blocked = 0;
-        var connect = -1;
+        // Order of events: request_start = 0, [proxy], [dns], [connect [ssl]], [send], receive_headers_end
+        // HAR 'blocked' time is time before first network activity.
+        // The rest time gaps will be classified as '_other'.
 
-        if (this._request.connectionReused)
-            blocked = waitForConnection;
-        else
-            connect = waitForConnection;
+        var dns = this._interval("dnsStart", "dnsEnd");
+        var send = this._interval("sendStart", "sendEnd");
+        var wait = this._interval("sendEnd", "receiveHeadersEnd");
+        var receive = WebInspector.HAREntry._toMilliseconds(this._request.receiveDuration);
+        var connect = this._request.connectionReused ? -1 : this._interval("connectStart", "connectEnd");
+
+        var blocked = -1;
+        var timing = this._request.timing;
+        if (timing) {
+            var events = ["dnsStart", "connectStart", "sendStart"];
+            var times = [];
+            for (var i = 0; i < events.length; ++i) {
+                var time = timing[events[i]];
+                if (typeof time === "number" && time !== -1)

[caseq, 2013/08/30 15:12:53]

Note that if (time >= 0) times.push(time) would work as well.

[eustas, 2013/09/13 15:10:36]

Done.

+                    times.push(time);
+            }
+            if (times.length)
+                blocked = Math.min.apply(null, times);

[caseq, 2013/08/30 15:12:53]

So what happened to the old logic of "if connection is reused, blocked time is
the time we waited for connection"?
Also, this loop is somewhat difficult to read.

[eustas, 2013/09/13 15:10:36]

It is baked into glue.

+        }
+
+        var total = WebInspector.HAREntry._toMilliseconds(this._request.duration);
+        var other = total - Math.max(blocked, 0) - Math.max(dns, 0) - Math.max(connect, 0) - Math.max(send, 0) - Math.max(wait, 0) - Math.max(receive, 0);
 
         return {
-            blocked: blocked,
-            dns: this._interval("dnsStart", "dnsEnd"),
-            connect: connect,
-            send: this._interval("sendStart", "sendEnd"),
-            wait: this._interval("sendEnd", "receiveHeadersEnd"),
-            receive: WebInspector.HAREntry._toMilliseconds(this._request.receiveDuration),
-            ssl: this._interval("sslStart", "sslEnd")
+            blocked: Math.round(blocked),
+            dns: Math.round(dns),
+            connect: Math.round(connect),
+            send: Math.round(send),
+            wait: Math.round(wait),
+            receive: Math.round(receive),
+            ssl: Math.round(this._interval("sslStart", "sslEnd")),
+            _other: Math.round(other)
         };
     },
 
     /**
      * @return {Object}
      */
     _buildPostData: function()
     {
         var res = {
             mimeType: this._request.requestHeaderValue("Content-Type"),
@@ skipping 52 matching lines @@
      * @param {string} start
      * @param {string} end
      * @return {number}
      */
     _interval: function(start, end)
     {
         var timing = this._request.timing;
         if (!timing)
             return -1;
         var startTime = timing[start];
-        return typeof startTime !== "number" || startTime === -1 ? -1 : Math.round(timing[end] - startTime);
+        return typeof startTime !== "number" || startTime === -1 ? -1 : (timing[end] - startTime);

[caseq, 2013/08/30 15:12:53]

Please remove redundant parenthesis.

[eustas, 2013/09/13 15:10:36]

Done.

     },
 
     /**
      * @return {number}
      */
     get requestBodySize()
     {
         return !this._request.requestFormData ? 0 : this._request.requestFormData.length;
     },
 
@@ skipping 17 matching lines @@
         return this._request.resourceSize - this.responseBodySize;
     }
 }
 
 /**
  * @param {number} time
  * @return {number}
  */
 WebInspector.HAREntry._toMilliseconds = function(time)
 {
-    return time === -1 ? -1 : Math.round(time * 1000);
+    return time === -1 ? -1 : (time * 1000);

[caseq, 2013/08/30 15:12:53]

Ditto.

[eustas, 2013/09/13 15:10:36]

Done.

 }
 
 /**
  * @constructor
  * @param {Array.<WebInspector.NetworkRequest>} requests
  */
 WebInspector.HARLog = function(requests)
 {
     this._requests = requests;
 }
@@ skipping 68 matching lines @@
     /**
      * @param {WebInspector.PageLoad} page
      * @param {number} time
      * @return {number}
      */
     _pageEventTime: function(page, time)
     {
         var startTime = page.startTime;
         if (time === -1 || startTime === -1)
             return -1;
-        return WebInspector.HAREntry._toMilliseconds(time - startTime);
+        return Math.round(WebInspector.HAREntry._toMilliseconds(time - startTime));
     }
 }
 
 /**
  * @constructor
  */
 WebInspector.HARWriter = function()
 {
 }
 
@@ skipping 66 matching lines @@
             this._writeProgress.done();
             return;
         }
         const chunkSize = 100000;
         var text = this._text.substring(this._bytesWritten, this._bytesWritten + chunkSize);
         this._bytesWritten += text.length;
         stream.write(text, this._writeNextChunk.bind(this));
         this._writeProgress.setWorked(this._bytesWritten);
     }
 }