Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 23308006: Introduce NavigatorOnLine interface (Closed)

Created:
7 years, 4 months ago by do-not-use
Modified:
7 years, 4 months ago
Reviewers:
haraken
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : No change #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -18 lines) Patch
M Source/core/core.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/page/Navigator.idl View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/page/NavigatorBase.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/page/NavigatorBase.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
A + Source/core/page/NavigatorOnLine.h View 1 chunk +13 lines, -6 lines 2 comments Download
A Source/core/page/NavigatorOnLine.idl View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/page/WorkerNavigator.idl View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
do-not-use
7 years, 4 months ago (2013-08-20 10:16:00 UTC) #1
haraken
LGTM https://codereview.chromium.org/23308006/diff/4001/Source/core/page/NavigatorOnLine.h File Source/core/page/NavigatorOnLine.h (right): https://codereview.chromium.org/23308006/diff/4001/Source/core/page/NavigatorOnLine.h#newcode38 Source/core/page/NavigatorOnLine.h:38: class NavigatorOnLine { Nit: Previously you used a ...
7 years, 4 months ago (2013-08-20 10:28:51 UTC) #2
do-not-use
https://codereview.chromium.org/23308006/diff/4001/Source/core/page/NavigatorOnLine.h File Source/core/page/NavigatorOnLine.h (right): https://codereview.chromium.org/23308006/diff/4001/Source/core/page/NavigatorOnLine.h#newcode38 Source/core/page/NavigatorOnLine.h:38: class NavigatorOnLine { On 2013/08/20 10:28:51, haraken wrote: > ...
7 years, 4 months ago (2013-08-20 10:31:48 UTC) #3
haraken
On 2013/08/20 10:31:48, Christophe Dumez wrote: > > Nit: Previously you used a namespace for ...
7 years, 4 months ago (2013-08-20 10:32:30 UTC) #4
do-not-use
Committed patchset #2 manually as r156392 (presubmit successful).
7 years, 4 months ago (2013-08-20 12:43:44 UTC) #5
Peter Beverloo
NavigatorOnLine.idl should probably have a license header.
7 years, 4 months ago (2013-08-20 12:45:42 UTC) #6
do-not-use
7 years, 4 months ago (2013-08-20 12:46:45 UTC) #7
Message was sent while issue was closed.
On 2013/08/20 12:45:42, Peter Beverloo wrote:
> NavigatorOnLine.idl should probably have a license header.

Sorry about that, I'll fix it straight away

Powered by Google App Engine
This is Rietveld 408576698