Issue 233073005: Mojo Spy: Fix a couple of bugs noticed by vtl@ and qsr@

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 233073005: Mojo Spy: Fix a couple of bugs noticed by vtl@ and qsr@ (Closed)

Created:
6 years, 8 months ago by cpu_(ooo_6.6-7.5)

Modified:
6 years, 8 months ago

Reviewers:
viettrungluu

CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Mojo Spy: Fix a couple of bugs noticed by vtl@ and qsr@ On WriteMessageRaw failure we own the handles, which we might want to log or keep but for correctness now we just close. BUG=none TBR=viettrungluu TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263090

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -4 lines)			Patch
	M	mojo/spy/spy.cc	View		3 chunks	+12 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cpu@chromium.org/233073005/1

6 years, 8 months ago (2014-04-10 18:04:18 UTC) #2

Message was sent while issue was closed.

Change committed as 263090

Expand Messages | Collapse Messages