Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1207)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 233073003: don't call (deprecated) getTotalClip (Closed)

Created:
6 years, 8 months ago by reed1
Modified:
6 years, 8 months ago
Reviewers:
michaelbai, boliu
CC:
chromium-reviews, android-webview-reviews_chromium.org
Visibility:
Public.

Description

don't call (deprecated) getTotalClip BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263118

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M android_webview/native/java_browser_view_renderer_helper.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
reed1
no functional change expected, just calling a different api to get the same thing.
6 years, 8 months ago (2014-04-10 14:23:12 UTC) #1
michaelbai
+boliu for graphic related change
6 years, 8 months ago (2014-04-10 16:41:48 UTC) #2
boliu
lgtm
6 years, 8 months ago (2014-04-10 16:44:44 UTC) #3
reed1
The CQ bit was checked by reed@google.com
6 years, 8 months ago (2014-04-10 19:27:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/233073003/1
6 years, 8 months ago (2014-04-10 19:27:39 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 23:08:47 UTC) #6
Message was sent while issue was closed. 
Change committed as 263118

Powered by Google App Engine
This is Rietveld 408576698