Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Unified Diff: Source/core/rendering/compositing/CompositingReasonFinder.cpp

Issue 233063004: Suppress layer creation for descendants of GPU-rasterized layers (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Move assert disabler in ~CompositedLayerMapping Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/compositing/CompositingReasonFinder.cpp
diff --git a/Source/core/rendering/compositing/CompositingReasonFinder.cpp b/Source/core/rendering/compositing/CompositingReasonFinder.cpp
index cf8b0f69651c903864cb9ebd1f8e10a2ef66d88b..f633c115d935f30c4acd32dd474bc659f189c5cd 100644
--- a/Source/core/rendering/compositing/CompositingReasonFinder.cpp
+++ b/Source/core/rendering/compositing/CompositingReasonFinder.cpp
@@ -89,6 +89,19 @@ bool CompositingReasonFinder::isMainFrame() const
return !m_renderView.document().ownerElement();
}
+CompositingReasons CompositingReasonFinder::suppressWillChangeAndAnimationForGpuRasterization(const RenderLayer* layer, CompositingReasons styleReasons) const
+{
+ CompositingReasons adjustedReasons = styleReasons;
+ adjustedReasons &= ~(CompositingReasonWillChangeCompositingHint | CompositingReasonWillChangeGpuRasterizationHint);
+
+ // We can suppress layer creation for animations before animations start, but not
+ // once they're already running on the compositor.
+ if (!layer->renderer()->style()->isRunningAnimationOnCompositor())
+ adjustedReasons &= ~CompositingReasonActiveAnimation;
+
+ return adjustedReasons;
+}
+
CompositingReasons CompositingReasonFinder::directReasons(const RenderLayer* layer, bool* needToRecomputeCompositingRequirements) const
{
CompositingReasons styleReasons = layer->styleDeterminedCompositingReasons();
@@ -127,8 +140,11 @@ CompositingReasons CompositingReasonFinder::styleDeterminedReasons(RenderObject*
if (requiresCompositingForFilters(renderer))
directReasons |= CompositingReasonFilters;
- if (requiresCompositingForWillChange(renderer))
- directReasons |= CompositingReasonWillChange;
+ if (requiresCompositingForWillChangeCompositingHint(renderer))
+ directReasons |= CompositingReasonWillChangeCompositingHint;
+
+ if (requiresCompositingForWillChangeGpuRasterizationHint(renderer))
+ directReasons |= CompositingReasonWillChangeGpuRasterizationHint;
ASSERT(!(directReasons & ~CompositingReasonComboAllStyleDeterminedReasons));
return directReasons;
@@ -160,11 +176,13 @@ bool CompositingReasonFinder::requiresCompositingForFilters(RenderObject* render
return renderer->hasFilter();
}
-bool CompositingReasonFinder::requiresCompositingForWillChange(const RenderObject* renderer) const
+bool CompositingReasonFinder::requiresCompositingForWillChangeCompositingHint(const RenderObject* renderer) const
{
- if (renderer->style()->hasWillChangeCompositingHint())
- return true;
+ return renderer->style()->hasWillChangeCompositingHint();
+}
+bool CompositingReasonFinder::requiresCompositingForWillChangeGpuRasterizationHint(const RenderObject* renderer) const
+{
if (!(m_compositingTriggers & GPURasterizationTrigger))
return false;

Powered by Google App Engine
This is Rietveld 408576698