Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2330593002: Show device connection and paired status in chooser on non-Mac (Closed)

Created:
4 years, 3 months ago by juncai
Modified:
4 years, 3 months ago
Reviewers:
msw
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Show device connection and paired status in chooser on non-Mac This CL added code to show an icon for connected device in the chooser, and added "- Paired" text after the device name if the device is paired. I uploaded some screenshots from ChromeOS in the issue page. BUG=543466 Committed: https://crrev.com/1d833f2314aa7857d2ed53a53cf0bb59ef5b69f9 Cr-Commit-Position: refs/heads/master@{#418916}

Patch Set 1 : show device connection and paired status in chooser on non-Mac #

Patch Set 2 : use ternary operator #

Total comments: 2

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -10 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/chooser_content_view.cc View 1 3 chunks +14 lines, -1 line 0 comments Download
M chrome/browser/ui/views/chooser_content_view_unittest.cc View 1 2 3 4 8 chunks +15 lines, -9 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 26 (20 generated)
juncai
Please take a look.
4 years, 3 months ago (2016-09-09 22:27:18 UTC) #6
msw
lgtm with a nit https://codereview.chromium.org/2330593002/diff/20001/chrome/browser/ui/views/chooser_content_view_unittest.cc File chrome/browser/ui/views/chooser_content_view_unittest.cc (right): https://codereview.chromium.org/2330593002/diff/20001/chrome/browser/ui/views/chooser_content_view_unittest.cc#newcode103 chrome/browser/ui/views/chooser_content_view_unittest.cc:103: EXPECT_EQ(l10n_util::GetStringFUTF16( nit: make a local ...
4 years, 3 months ago (2016-09-09 23:16:03 UTC) #7
juncai
https://codereview.chromium.org/2330593002/diff/20001/chrome/browser/ui/views/chooser_content_view_unittest.cc File chrome/browser/ui/views/chooser_content_view_unittest.cc (right): https://codereview.chromium.org/2330593002/diff/20001/chrome/browser/ui/views/chooser_content_view_unittest.cc#newcode103 chrome/browser/ui/views/chooser_content_view_unittest.cc:103: EXPECT_EQ(l10n_util::GetStringFUTF16( On 2016/09/09 23:16:03, msw wrote: > nit: make ...
4 years, 3 months ago (2016-09-15 17:43:55 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2330593002/80001
4 years, 3 months ago (2016-09-15 18:39:27 UTC) #23
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 3 months ago (2016-09-15 18:46:22 UTC) #24
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 18:48:49 UTC) #26
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/1d833f2314aa7857d2ed53a53cf0bb59ef5b69f9
Cr-Commit-Position: refs/heads/master@{#418916}

Powered by Google App Engine
This is Rietveld 408576698