Show crash report size in crashes UI for Android.

components/crash/core/browser/crashes_ui_util.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/crash/core/browser/crashes_ui_util.h"
 
 #include <memory>
 #include <utility>
 #include <vector>
 
 #include "base/i18n/time_formatting.h"
 #include "base/macros.h"
+#include "base/strings/string_number_conversions.h"
 #include "base/values.h"
 #include "components/upload_list/upload_list.h"
 #include "grit/components_chromium_strings.h"
 #include "grit/components_strings.h"
 
 namespace crash {
 
 const CrashesUILocalizedString kCrashesUILocalizedStrings[] = {
     {"bugLinkText", IDS_CRASH_BUG_LINK_LABEL},
     {"crashCountFormat", IDS_CRASH_CRASH_COUNT_BANNER_FORMAT},
     {"crashHeaderFormat", IDS_CRASH_CRASH_HEADER_FORMAT},
     {"crashHeaderFormatLocalOnly", IDS_CRASH_CRASH_HEADER_FORMAT_LOCAL_ONLY},
     {"crashTimeFormat", IDS_CRASH_CRASH_TIME_FORMAT},
     {"crashNotUploaded", IDS_CRASH_CRASH_NOT_UPLOADED},
     {"crashUserRequested", IDS_CRASH_CRASH_USER_REQUESTED},
     {"crashPending", IDS_CRASH_CRASH_PENDING},
     {"crashesTitle", IDS_CRASH_TITLE},
     {"disabledHeader", IDS_CRASH_DISABLED_HEADER},
     {"disabledMessage", IDS_CRASH_DISABLED_MESSAGE},
     {"noCrashesMessage", IDS_CRASH_NO_CRASHES_MESSAGE},
     {"uploadCrashesLinkText", IDS_CRASH_UPLOAD_MESSAGE},
     {"uploadNowLinkText", IDS_CRASH_UPLOAD_NOW_LINK_TEXT},
+    {"crashSizeMessage", IDS_CRASH_SIZE_MESSAGE},
 };
 
 const size_t kCrashesUILocalizedStringsCount =
     arraysize(kCrashesUILocalizedStrings);
 
 const char kCrashesUICrashesJS[] = "crashes.js";
 const char kCrashesUIRequestCrashList[] = "requestCrashList";
 const char kCrashesUIRequestCrashUpload[] = "requestCrashUpload";
 const char kCrashesUIShortProductName[] = "shortProductName";
 const char kCrashesUIUpdateCrashList[] = "updateCrashList";
@@ skipping 24 matching lines @@
     crash->SetString("id", info.upload_id);
     if (info.state == UploadList::UploadInfo::State::Uploaded) {
       crash->SetString("time",
                        base::TimeFormatFriendlyDateAndTime(info.upload_time));
     } else {
       crash->SetString("time",
                        base::TimeFormatFriendlyDateAndTime(info.capture_time));
     }
     crash->SetString("local_id", info.local_id);
     crash->SetString("state", UploadInfoStateAsString(info.state));
+    crash->SetString("file_size", info.file_size == 0

[Mark Mentovai, 2016/09/13 16:13:25]

A crash report’s might accidentally wind up as 0 bytes because of some kind of
problem. I think that we should pass it through and display it even in this case
to help troubleshooting.

We only wouldn’t want to show a size in cases where we can’t get the file size,
like non-Android platforms since you’re currently only implementing this for
Android.

[gayane -on leave until 09-2017, 2016/09/13 17:40:23]

Done.

+                                      ? ""
+                                      : base::IntToString(info.file_size));
     out_value->Append(std::move(crash));
   }
 }
 
 }  // namespace crash