Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Issue 2330553002: Disallow resizing on OffscreenCanvas that has been transferred control from canvas (Closed)

Created:
4 years, 3 months ago by xlai (Olivia)
Modified:
4 years, 3 months ago
Reviewers:
Justin Novosad
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disallow resizing on OffscreenCanvas that has been transferred control from canvas In my previous patch (https://codereview.chromium.org/2294963002/) I had some primitive ideas about disallowing resizing on OffscreenCanvas. This CL makes it more assertive by throwing exception (not just causing no effect) to alert users. BUG=563852 Committed: https://crrev.com/9237ff22c578869bbb2615f5ce2f17b3b05be6c1 Cr-Commit-Position: refs/heads/master@{#417951}

Patch Set 1 #

Patch Set 2 : test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -13 lines) Patch
M third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-transferControlToOffscreen.html View 1 1 chunk +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp View 1 chunk +8 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.idl View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
xlai (Olivia)
4 years, 3 months ago (2016-09-12 14:26:12 UTC) #4
Justin Novosad
Yes! I will make sure this is in the spec. lgtm
4 years, 3 months ago (2016-09-12 14:37:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2330553002/40001
4 years, 3 months ago (2016-09-12 14:41:49 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 3 months ago (2016-09-12 16:17:51 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 16:20:52 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9237ff22c578869bbb2615f5ce2f17b3b05be6c1
Cr-Commit-Position: refs/heads/master@{#417951}

Powered by Google App Engine
This is Rietveld 408576698