Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 233053005: Add a focused public API for src/record. (Closed)

Created:
6 years, 8 months ago by mtklein_C
Modified:
6 years, 8 months ago
CC:
skia-review_googlegroups.com, f(malita)
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Add a focused public API for src/record. BUG=skia:2378 Committed: http://code.google.com/p/skia/source/detail?r=14146

Patch Set 1 #

Patch Set 2 : make constructor private #

Patch Set 3 : wrap in EXPERIMENTAL #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -2 lines) Patch
M gyp/record.gyp View 1 chunk +5 lines, -2 lines 0 comments Download
M gyp/tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A include/record/SkRecording.h View 1 2 1 chunk +67 lines, -0 lines 1 comment Download
A src/record/SkRecording.cpp View 1 2 1 chunk +44 lines, -0 lines 1 comment Download
A tests/RecordingTest.cpp View 1 2 1 chunk +18 lines, -0 lines 1 comment Download

Messages

Total messages: 9 (0 generated)
mtklein
6 years, 8 months ago (2014-04-10 19:56:43 UTC) #1
mtklein
On 2014/04/10 19:56:43, mtklein wrote: FYI, just make the SkPlayback constructor private instead of taunting ...
6 years, 8 months ago (2014-04-10 20:12:10 UTC) #2
reed1
Lets add some form of /** EXPERIMENTAL */ to the header and/or class names for ...
6 years, 8 months ago (2014-04-10 20:12:27 UTC) #3
mtklein
On 2014/04/10 20:12:27, reed1 wrote: > Lets add some form of /** EXPERIMENTAL */ to ...
6 years, 8 months ago (2014-04-10 20:19:20 UTC) #4
f(malita)
lgtm
6 years, 8 months ago (2014-04-10 20:30:38 UTC) #5
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 8 months ago (2014-04-10 22:06:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/233053005/40001
6 years, 8 months ago (2014-04-10 22:06:59 UTC) #7
commit-bot: I haz the power
Change committed as 14146
6 years, 8 months ago (2014-04-10 23:31:09 UTC) #8
robertphillips
6 years, 8 months ago (2014-04-11 13:28:07 UTC) #9
Message was sent while issue was closed.
Just a nit about missing headers.

https://codereview.chromium.org/233053005/diff/40001/include/record/SkRecordi...
File include/record/SkRecording.h (right):

https://codereview.chromium.org/233053005/diff/40001/include/record/SkRecordi...
include/record/SkRecording.h:1: #ifndef SkRecording_DEFINED
Header?

https://codereview.chromium.org/233053005/diff/40001/src/record/SkRecording.cpp
File src/record/SkRecording.cpp (right):

https://codereview.chromium.org/233053005/diff/40001/src/record/SkRecording.c...
src/record/SkRecording.cpp:1: #include "SkRecording.h"
Header?

https://codereview.chromium.org/233053005/diff/40001/tests/RecordingTest.cpp
File tests/RecordingTest.cpp (right):

https://codereview.chromium.org/233053005/diff/40001/tests/RecordingTest.cpp#...
tests/RecordingTest.cpp:1: #include "Test.h"
Header?

Powered by Google App Engine
This is Rietveld 408576698