Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: tests/standalone/io/file_invalid_arguments_test.dart

Issue 233053004: Fix File:copy FD leak, and add file-closes to some tests. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/standalone/io/file_input_stream_test.dart ('k') | tests/standalone/io/file_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/io/file_invalid_arguments_test.dart
diff --git a/tests/standalone/io/file_invalid_arguments_test.dart b/tests/standalone/io/file_invalid_arguments_test.dart
index d66c458404928c1d698f195f15eb924405706d1a..58c6d7c423e54fa9f8a66fb082b823244cf69161 100644
--- a/tests/standalone/io/file_invalid_arguments_test.dart
+++ b/tests/standalone/io/file_invalid_arguments_test.dart
@@ -16,6 +16,7 @@ void testReadInvalidArgs(arg) {
Expect.throws(() => file.read(arg),
(e) => e is ArgumentError);
+ file.closeSync();
}
void testReadIntoInvalidArgs(buffer, start, end) {
@@ -26,6 +27,7 @@ void testReadIntoInvalidArgs(buffer, start, end) {
Expect.throws(() => file.readInto(buffer, start, end),
(e) => e is ArgumentError);
+ file.closeSync();
}
void testWriteByteInvalidArgs(value) {
@@ -36,6 +38,7 @@ void testWriteByteInvalidArgs(value) {
Expect.throws(() => file.writeByte(value),
(e) => e is ArgumentError);
+ file.closeSync();
}
void testWriteFromInvalidArgs(buffer, start, end) {
@@ -46,6 +49,7 @@ void testWriteFromInvalidArgs(buffer, start, end) {
Expect.throws(() => file.writeFrom(buffer, start, end),
(e) => e is ArgumentError);
+ file.closeSync();
}
void testWriteStringInvalidArgs(string, encoding) {
@@ -56,6 +60,7 @@ void testWriteStringInvalidArgs(string, encoding) {
Expect.throws(() => file.writeString(string, encoding: encoding),
(e) => e is ArgumentError);
+ file.closeSync();
}
Future futureThrows(Future result) {
« no previous file with comments | « tests/standalone/io/file_input_stream_test.dart ('k') | tests/standalone/io/file_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698