Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 233053003: Remove obsolete scale related APIs for cursor (Closed)

Created:
6 years, 8 months ago by oshima
Modified:
6 years, 8 months ago
CC:
chromium-reviews, ben+aura_chromium.org, tfarina, sadrul, kalyank, ben+views_chromium.org, ben+ash_chromium.org
Visibility:
Public.

Description

Remove obsolete scale related APIs for cursor This has been replaced with SetDisplay a while ago. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263043 R=ben@chromium.org, tdanderson@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263061

Patch Set 1 : #

Patch Set 2 : fix wm_core_unittests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -119 lines) Patch
M ash/test/cursor_manager_test_api.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/test/cursor_manager_test_api.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ash/wm/ash_native_cursor_manager.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/wm/ash_native_cursor_manager.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M ash/wm/ash_native_cursor_manager_unittest.cc View 4 chunks +0 lines, -23 lines 0 comments Download
M ui/aura/client/cursor_client.h View 1 chunk +0 lines, -6 lines 0 comments Download
M ui/aura/test/test_cursor_client.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/aura/test/test_cursor_client.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_cursor_manager.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_cursor_manager.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M ui/wm/core/cursor_manager.h View 2 chunks +0 lines, -3 lines 0 comments Download
M ui/wm/core/cursor_manager.cc View 5 chunks +0 lines, -21 lines 0 comments Download
M ui/wm/core/cursor_manager_unittest.cc View 1 2 chunks +0 lines, -23 lines 0 comments Download
M ui/wm/core/native_cursor_manager.h View 1 chunk +1 line, -6 lines 0 comments Download
M ui/wm/core/native_cursor_manager_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
oshima
6 years, 8 months ago (2014-04-10 17:12:31 UTC) #1
Ben Goodger (Google)
lgtm
6 years, 8 months ago (2014-04-10 17:19:42 UTC) #2
tdanderson
LGTM
6 years, 8 months ago (2014-04-10 17:24:29 UTC) #3
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 8 months ago (2014-04-10 17:48:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/233053003/20001
6 years, 8 months ago (2014-04-10 17:49:09 UTC) #5
commit-bot: I haz the power
Change committed as 263043
6 years, 8 months ago (2014-04-10 19:10:37 UTC) #6
oshima
Committed patchset #2 manually as r263061 (presubmit successful).
6 years, 8 months ago (2014-04-10 20:09:40 UTC) #7
oshima
6 years, 8 months ago (2014-04-10 20:20:01 UTC) #8
Message was sent while issue was closed. 
On 2014/04/10 20:09:40, oshima wrote:
> Committed patchset #2 manually as r263061 (presubmit successful).

CL passed CQ because they did not build wm_core_unittests (a bug is filed for
this).
I fixed wm_core_unittests and tested locally. (Just simple code removal)

Powered by Google App Engine
This is Rietveld 408576698