Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 2330513002: Temporarily stop honoring text-size-adjust as it breaks accessibility (Closed)

Created:
4 years, 3 months ago by pdr.
Modified:
4 years, 3 months ago
Reviewers:
skobes
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Temporarily stop honoring text-size-adjust as it breaks accessibility This patch temporarily diables text-size-adjust from affecting the text autosizer because the accessibility font size adjustment also uses the text autosizer and sites should not be able to disable the accessibility settings. This is a temporary change. A proper fix will be coming in a followup. Text-size-adjust support was added in: https://crrev.com/5365b8ad85c2f5cee6034b8baea3c764ed78e1ea BUG=645269 Committed: https://crrev.com/4e8989e66c9cb0e427ea886dfc5ef51ef0e4e836 Cr-Commit-Position: refs/heads/master@{#417738}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M third_party/WebKit/Source/core/layout/TextAutosizer.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/TextAutosizerTest.cpp View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
pdr.
4 years, 3 months ago (2016-09-09 18:24:07 UTC) #4
skobes
lgtm
4 years, 3 months ago (2016-09-09 18:30:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2330513002/1
4 years, 3 months ago (2016-09-09 18:46:45 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-09 22:39:00 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 22:41:10 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4e8989e66c9cb0e427ea886dfc5ef51ef0e4e836
Cr-Commit-Position: refs/heads/master@{#417738}

Powered by Google App Engine
This is Rietveld 408576698