Class fields, part 3 (backends)

src/full-codegen/mips/full-codegen-mips.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #if V8_TARGET_ARCH_MIPS
 
 // Note on Mips implementation:
 //
 // The result_register() for mips is the 'v0' register, which is defined
 // by the ABI to contain function return values. However, the first
@@ skipping 1971 matching lines @@
   __ bind(&done);
   context()->Plug(v0);
 }
 
 
 void FullCodeGenerator::EmitClassDefineProperties(ClassLiteral* lit) {
   for (int i = 0; i < lit->properties()->length(); i++) {
     ClassLiteral::Property* property = lit->properties()->at(i);
     Expression* value = property->value();
 
+    if (property->kind() == ClassLiteral::Property::FIELD &&
+        !property->is_static()) {
+      // Non-static properties produced by the parser have as their 'key' an
+      // expression producing their name and as their 'value' a variable which
+      // is refered to by the synthetic initializer function in order to
+      // determine the name during class instantiation. This is necessary
+      // because computed names must only be evaluated once, at class definition
+      // time.
+      // That is, code which looks like `class C { [f()] = 1; }` is desugared
+      // into something like
+      // class C { constructor(){ this.[.class-field-0-name] = 1; } };
+      // let .class-field-0-name = f();
+      // except that the assignment to .class-field-name-0 occurs interleaved
+      // with the rest of the class body; it is performed by the block in which
+      // this comment appears.
+      DCHECK(property->value()->IsVariableProxy());
+      Variable* variable = property->value()->AsVariableProxy()->var();
+      VisitForStackValue(property->key());
+      EmitVariableAssignment(variable, Token::INIT,
+                             FeedbackVectorSlot::Invalid());
+      DropOperands(1);
+      continue;
+    }
+
     Register scratch = a1;
     if (property->is_static()) {
       __ lw(scratch, MemOperand(sp, kPointerSize));  // constructor
     } else {
       __ lw(scratch, MemOperand(sp, 0));  // prototype
     }
     PushOperand(scratch);
     EmitPropertyKey(property, lit->GetIdForProperty(i));
 
     // The static prototype property is read only. We handle the non computed
@@ skipping 21 matching lines @@
         PushOperand(Smi::FromInt(DONT_ENUM));
         CallRuntimeWithOperands(Runtime::kDefineGetterPropertyUnchecked);
         break;
 
       case ClassLiteral::Property::SETTER:
         PushOperand(Smi::FromInt(DONT_ENUM));
         CallRuntimeWithOperands(Runtime::kDefineSetterPropertyUnchecked);
         break;
 
       case ClassLiteral::Property::FIELD:
-      default:
-        UNREACHABLE();
+        DCHECK(property->is_static());
+        PushOperand(Smi::FromInt(DONT_ENUM));
+        PushOperand(Smi::FromInt(property->NeedsSetFunctionName()));
+        CallRuntimeWithOperands(Runtime::kDefineDataPropertyInLiteral);
+        break;
     }
   }
 }
 
 
 void FullCodeGenerator::EmitBinaryOp(BinaryOperation* expr, Token::Value op) {
   __ mov(a0, result_register());
   PopOperand(a1);
   Handle<Code> code = CodeFactory::BinaryOpIC(isolate(), op).code();
   JumpPatchSite patch_site(masm_);    // unbound, signals no inlined smi code.
@@ skipping 1694 matching lines @@
          reinterpret_cast<uint32_t>(
              isolate->builtins()->OnStackReplacement()->entry()));
   return ON_STACK_REPLACEMENT;
 }
 
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_TARGET_ARCH_MIPS