Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2330413004: reduce the relevance of completions starting with "$" (Closed)

Created:
4 years, 3 months ago by danrubel
Modified:
4 years, 3 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M pkg/analysis_server/lib/src/services/completion/dart/type_member_contributor.dart View 1 chunk +9 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/type_member_contributor_test.dart View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
4 years, 3 months ago (2016-09-13 18:01:39 UTC) #2
scheglov
LGTM
4 years, 3 months ago (2016-09-13 18:04:49 UTC) #3
danrubel
4 years, 3 months ago (2016-09-13 18:21:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4fce5e9022acabf3673694e96370e752eb597676 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698