Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Unified Diff: ash/common/system/chromeos/tray_tracing.cc

Issue 2330403002: Do not activate system tray bubble by default (Closed)
Patch Set: Do not activate system tray bubble Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/common/system/chromeos/tray_tracing.cc
diff --git a/ash/common/system/chromeos/tray_tracing.cc b/ash/common/system/chromeos/tray_tracing.cc
index e1ac45f5d5a4814487c187c1867c9a67670eb65a..03ebe68f113495696be121106bc93115023e458d 100644
--- a/ash/common/system/chromeos/tray_tracing.cc
+++ b/ash/common/system/chromeos/tray_tracing.cc
@@ -28,7 +28,7 @@ namespace tray {
class DefaultTracingView : public ActionableView {
public:
- DefaultTracingView() {
+ DefaultTracingView(SystemTrayItem* owner) : ActionableView(owner) {
James Cook 2016/09/22 21:17:16 explicit
oshima 2016/09/23 09:37:19 Done.
SetLayoutManager(new views::BoxLayout(views::BoxLayout::kHorizontal,
kTrayPopupPaddingHorizontal, 0,
kTrayPopupPaddingBetweenItems));
@@ -62,6 +62,7 @@ class DefaultTracingView : public ActionableView {
WmShell::Get()->RecordUserMetricsAction(
UMA_STATUS_AREA_TRACING_DEFAULT_SELECTED);
WmShell::Get()->system_tray_delegate()->ShowChromeSlow();
+ CloseSystemBubble();
return true;
}
@@ -99,7 +100,7 @@ bool TrayTracing::GetInitialVisibility() {
views::View* TrayTracing::CreateDefaultView(LoginStatus status) {
CHECK(default_ == NULL);
if (tray_view() && tray_view()->visible())
- default_ = new tray::DefaultTracingView();
+ default_ = new tray::DefaultTracingView(this);
return default_;
}

Powered by Google App Engine
This is Rietveld 408576698