Snapshot i18n Javascript code

Snapshot i18n Javascript code

BUG=v8:2745
R=mstarzinger@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=16298

[Michael Starzinger, 2013-08-20 09:49:29]

LGTM.

https://codereview.chromium.org/23304005/diff/1/src/i18n.js
File src/i18n.js (right):

https://codereview.chromium.org/23304005/diff/1/src/i18n.js#newcode29
src/i18n.js:29: // ECMAScript 402 API implementation is broken into separate
files for
This file is rubber-stamped under the assumption that it is just a concatenation
of preexisting JS files.

[jochen (gone - plz use gerrit), 2013-08-20 09:51:26]

https://codereview.chromium.org/23304005/diff/1/src/i18n.js
File src/i18n.js (right):

https://codereview.chromium.org/23304005/diff/1/src/i18n.js#newcode29
src/i18n.js:29: // ECMAScript 402 API implementation is broken into separate
files for
On 2013/08/20 09:49:29, Michael Starzinger wrote:
> This file is rubber-stamped under the assumption that it is just a
concatenation
> of preexisting JS files.

I had to delay the construction of RegExp objects because RegExp objects can't
be in the snapshot, and replace a bunch of objects with $objects (e.g.
RangeError with $RangeError)

[Michael Starzinger, 2013-08-20 09:59:14]

On 2013/08/20 09:51:26, jochen wrote:
> https://codereview.chromium.org/23304005/diff/1/src/i18n.js
> File src/i18n.js (right):
> 
> https://codereview.chromium.org/23304005/diff/1/src/i18n.js#newcode29
> src/i18n.js:29: // ECMAScript 402 API implementation is broken into separate
> files for
> On 2013/08/20 09:49:29, Michael Starzinger wrote:
> > This file is rubber-stamped under the assumption that it is just a
> concatenation
> > of preexisting JS files.
> 
> I had to delay the construction of RegExp objects because RegExp objects can't
> be in the snapshot, and replace a bunch of objects with $objects (e.g.
> RangeError with $RangeError)

In general the i18n.js file should be integrated to use more of V8's internal
functionality. But all of that is stuff for follow-up CLs. Some examples are:
1) Using MakeRangeError instead of "new $RangeError".
2) Not have global code but do all of the initialization in one SetUpIntl
function.
3) Not wrap everything in one function scope but have the implementation methods
be available on the builtin global object.
4) Use the InstallFunctions helper
5) Adhere to the naming convention in other builtin JS files.

[jochen (gone - plz use gerrit), 2013-08-23 13:25:11]

Committed patchset #2 manually as r16298 (presubmit successful).