Issue 23304003: Revert 218338 "Resubmit issue to fix issue where window bounds w..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23304003: Revert 218338 "Resubmit issue to fix issue where window bounds w..." (Closed)

Created:
7 years, 4 months ago by scottmg

Modified:
7 years, 4 months ago

Reviewers:
zturner

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 218338 "Resubmit issue to fix issue where window bounds w..." Causing problems on CrOS still. > Resubmit issue to fix issue where window bounds were being passed with > wrong coordinates. > > This is a speculative re-upload as the previous change was reverted with > mysterious failures which seemed unrelated to my change. It has been > more than 1 week, and being unable to find any reason for the failures, > will try again with the same commit to see if the issues resurface. > > Original review URL: > https://codereview.chromium.org/19681003/ > > BUG=176221 > TBR=sky > > Review URL: https://chromiumcodereview.appspot.com/22848003 TBR=zturner@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218365

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+57 lines, -140 lines)			Patch
M	trunk/src/content/browser/renderer_host/render_widget_host_impl.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	trunk/src/content/browser/renderer_host/render_widget_host_view_aura.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	trunk/src/content/browser/renderer_host/render_widget_host_view_aura.cc	View	3 chunks	+56 lines, -64 lines	0 comments	Download
M	trunk/src/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc	View	3 chunks	+0 lines, -71 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r218365.

Expand Messages | Collapse Messages