content/browser/renderer_host/media/audio_renderer_host_unittest.cc - Issue 2330393002: Change sync primitives ownership for audio rendering.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/media/audio_renderer_host_unittest.cc

Issue 2330393002: Change sync primitives ownership for audio rendering. (Closed)

Patch Set: Remove incorrect comment. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/media/audio_renderer_host.cc ('K') | « content/browser/renderer_host/media/audio_renderer_host.cc ('k') | content/browser/renderer_host/media/audio_sync_reader.h » ('j') | content/browser/renderer_host/media/audio_sync_reader.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/media/audio_renderer_host_unittest.cc

diff --git a/content/browser/renderer_host/media/audio_renderer_host_unittest.cc b/content/browser/renderer_host/media/audio_renderer_host_unittest.cc

index de61c1f708671b667a4ba8e325588b159f9e6eaa..020d5389263f5c0b9a4f849cd0723a86494d45cd 100644

--- a/content/browser/renderer_host/media/audio_renderer_host_unittest.cc

+++ b/content/browser/renderer_host/media/audio_renderer_host_unittest.cc

@@ -109,6 +109,8 @@ class MockAudioRendererHost : public AudioRendererHost {

// This method is used to dispatch IPC messages to the renderer. We intercept

// these messages here and dispatch to our mock methods to verify the

// conversation between this object and the renderer.

+ // Note: this means that file descriptors won't be duplicated,

+ // leading to double-close errors from SyncSocket.

o1ka 2016/09/16 10:51:59 Can you file a bug and refer it here?

Max Morin 2016/09/16 12:46:15 Done.

virtual bool Send(IPC::Message* message) {

CHECK(message);