Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2330353007: Add usage counters to XSSAuditor. (Closed)

Created:
4 years, 3 months ago by Mike West
Modified:
4 years, 2 months ago
Reviewers:
Tom Sepez
CC:
asvitkine+watch_chromium.org, blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, kinuko+watch, loading-reviews+parser_chromium.org, fbraun_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add usage counters to XSSAuditor. BUG=642747 Committed: https://crrev.com/239fdac4d03219287e6f8aef8e7f372f615e2a2b Cr-Commit-Position: refs/heads/master@{#420892}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/XSSAuditor.cpp View 1 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/XSSAuditorDelegate.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
Mike West
Tom, WDYT?
4 years, 3 months ago (2016-09-15 08:53:19 UTC) #4
Tom Sepez
lgtm https://codereview.chromium.org/2330353007/diff/1/third_party/WebKit/Source/core/frame/UseCounter.h File third_party/WebKit/Source/core/frame/UseCounter.h (right): https://codereview.chromium.org/2330353007/diff/1/third_party/WebKit/Source/core/frame/UseCounter.h#newcode1300 third_party/WebKit/Source/core/frame/UseCounter.h:1300: XSSAuditorBlockedScriptAndEntirePage = 1559, nit: maybe just call this ...
4 years, 3 months ago (2016-09-15 16:39:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2330353007/20001
4 years, 2 months ago (2016-09-26 07:34:19 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/299454)
4 years, 2 months ago (2016-09-26 09:21:24 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2330353007/20001
4 years, 2 months ago (2016-09-26 11:27:38 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/147945)
4 years, 2 months ago (2016-09-26 14:03:01 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2330353007/20001
4 years, 2 months ago (2016-09-26 14:25:51 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-26 15:44:30 UTC) #19
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 15:46:59 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/239fdac4d03219287e6f8aef8e7f372f615e2a2b
Cr-Commit-Position: refs/heads/master@{#420892}

Powered by Google App Engine
This is Rietveld 408576698