Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1012)

Unified Diff: third_party/WebKit/Source/platform/animation/TimingFunctionTest.cpp

Issue 2330283004: Fix serialization of step timing functions (Closed)
Patch Set: Update step timing function parsing in devtools Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/animation/TimingFunction.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/animation/TimingFunctionTest.cpp
diff --git a/third_party/WebKit/Source/platform/animation/TimingFunctionTest.cpp b/third_party/WebKit/Source/platform/animation/TimingFunctionTest.cpp
index 8867d13968b8094161f820398ba6e5b03ba982b1..96531af6b40ac33bddbab081769f601ea494238e 100644
--- a/third_party/WebKit/Source/platform/animation/TimingFunctionTest.cpp
+++ b/third_party/WebKit/Source/platform/animation/TimingFunctionTest.cpp
@@ -89,13 +89,13 @@ TEST_F(TimingFunctionTest, CubicToString)
TEST_F(TimingFunctionTest, StepToString)
{
RefPtr<TimingFunction> stepTimingStart = StepsTimingFunction::preset(StepsTimingFunction::StepPosition::START);
- EXPECT_EQ("step-start", stepTimingStart->toString());
+ EXPECT_EQ("steps(1, start)", stepTimingStart->toString());
RefPtr<TimingFunction> stepTimingMiddle = StepsTimingFunction::preset(StepsTimingFunction::StepPosition::MIDDLE);
- EXPECT_EQ("step-middle", stepTimingMiddle->toString());
+ EXPECT_EQ("steps(1, middle)", stepTimingMiddle->toString());
RefPtr<TimingFunction> stepTimingEnd = StepsTimingFunction::preset(StepsTimingFunction::StepPosition::END);
- EXPECT_EQ("step-end", stepTimingEnd->toString());
+ EXPECT_EQ("steps(1)", stepTimingEnd->toString());
RefPtr<TimingFunction> stepTimingCustomStart = StepsTimingFunction::create(3, StepsTimingFunction::StepPosition::START);
EXPECT_EQ("steps(3, start)", stepTimingCustomStart->toString());
@@ -104,7 +104,7 @@ TEST_F(TimingFunctionTest, StepToString)
EXPECT_EQ("steps(4, middle)", stepTimingCustomMiddle->toString());
RefPtr<TimingFunction> stepTimingCustomEnd = StepsTimingFunction::create(5, StepsTimingFunction::StepPosition::END);
- EXPECT_EQ("steps(5, end)", stepTimingCustomEnd->toString());
+ EXPECT_EQ("steps(5)", stepTimingCustomEnd->toString());
}
TEST_F(TimingFunctionTest, BaseOperatorEq)
« no previous file with comments | « third_party/WebKit/Source/platform/animation/TimingFunction.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698