Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2330253002:
Add access to Physical Web Service results (Closed)
|
Created:
4 years, 3 months ago by hayesjordan Modified:
4 years, 3 months ago CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd access to Physical Web Service results
To allow access to Physical Web data, the URL info and Physical Web
Service data needs to be paired together. The pairing gives all relevant
information for a scanned URL.
BUG=636490
Committed: https://crrev.com/576c1dde62f1bc26e4366d50b32f76a636a1dbbd
Committed: https://crrev.com/394cd0ae7e135631c6fdb2b41ad651edd65d57b5
Cr-Original-Commit-Position: refs/heads/master@{#419531}
Cr-Commit-Position: refs/heads/master@{#419603}
Patch Set 1 #Patch Set 2 : Fix broken tests #
Total comments: 3
Patch Set 3 : Address cco3 comments #Patch Set 4 : Address in person discussion #
Total comments: 8
Patch Set 5 : Address cco3 comments #Patch Set 6 : Fix find bugs errors #
Messages
Total messages: 36 (15 generated)
Description was changed from ========== Add access to Physical Web Service results To allow access to Physical Web data, the URL info and Physical Web Service data needs to be paired together. The pairing gives all relevant information for a scanned URL. bug=636490 BUG= ========== to ========== Add access to Physical Web Service results To allow access to Physical Web data, the URL info and Physical Web Service data needs to be paired together. The pairing gives all relevant information for a scanned URL. BUG=636490 ==========
hayesjordan@google.com changed reviewers: + cco3@chromium.org
The CQ bit was checked by hayesjordan@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
https://codereview.chromium.org/2330253002/diff/20001/chrome/android/java/src... File chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java (right): https://codereview.chromium.org/2330253002/diff/20001/chrome/android/java/src... chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java:260: pairs.add(new PwPair(mUrlInfoMap.get(pwsResult.requestUrl), pwsResult)); When we have an ID other than URLs, this will not get every pair. You should loop through the UrlInfos first. Also, are we sure we want this function directly here in java (instead of synthesizing the data into pairs in c++?)
https://codereview.chromium.org/2330253002/diff/20001/chrome/android/java/src... File chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java (right): https://codereview.chromium.org/2330253002/diff/20001/chrome/android/java/src... chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java:260: pairs.add(new PwPair(mUrlInfoMap.get(pwsResult.requestUrl), pwsResult)); On 2016/09/16 18:11:49, cco3 wrote: > When we have an ID other than URLs, this will not get every pair. You should > loop through the UrlInfos first. Also, are we sure we want this function > directly here in java (instead of synthesizing the data into pairs in c++?) Would that mean the returned list could have multiple pairs with the same PwsResult? If we have ID other than URLs for mUrlInfoMap wouldn't that break line 322? So just return have a function that returns an array of PwsResults and a function that returns an array of UrlInfos?
https://codereview.chromium.org/2330253002/diff/20001/chrome/android/java/src... File chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java (right): https://codereview.chromium.org/2330253002/diff/20001/chrome/android/java/src... chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java:260: pairs.add(new PwPair(mUrlInfoMap.get(pwsResult.requestUrl), pwsResult)); On 2016/09/16 18:30:10, hayesjordan wrote: > On 2016/09/16 18:11:49, cco3 wrote: > > When we have an ID other than URLs, this will not get every pair. You should > > loop through the UrlInfos first. Also, are we sure we want this function > > directly here in java (instead of synthesizing the data into pairs in c++?) > > Would that mean the returned list could have multiple pairs with the same > PwsResult? Yes > > If we have ID other than URLs for mUrlInfoMap wouldn't that break line 322? We'd need to do a reverse lookup of UrlInfos at that point, at least later on in the call stack, when distance and beacon info becomes important. > > So just return have a function that returns an array of PwsResults and a > function that returns an array of UrlInfos? I don't know...let's talk about how this will be used.
On 2016/09/16 18:33:56, cco3 wrote: > https://codereview.chromium.org/2330253002/diff/20001/chrome/android/java/src... > File > chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java > (right): > > https://codereview.chromium.org/2330253002/diff/20001/chrome/android/java/src... > chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java:260: > pairs.add(new PwPair(mUrlInfoMap.get(pwsResult.requestUrl), pwsResult)); > On 2016/09/16 18:30:10, hayesjordan wrote: > > On 2016/09/16 18:11:49, cco3 wrote: > > > When we have an ID other than URLs, this will not get every pair. You > should > > > loop through the UrlInfos first. Also, are we sure we want this function > > > directly here in java (instead of synthesizing the data into pairs in c++?) > > > > Would that mean the returned list could have multiple pairs with the same > > PwsResult? > > Yes Updated > > > > > If we have ID other than URLs for mUrlInfoMap wouldn't that break line 322? > > We'd need to do a reverse lookup of UrlInfos at that point, at least later on in > the call stack, when distance and beacon info becomes important. > > > > > So just return have a function that returns an array of PwsResults and a > > function that returns an array of UrlInfos? > > I don't know...let's talk about how this will be used.
LGTM
On 2016/09/16 20:28:19, cco3 wrote: > LGTM Please update as discussed in person.
On 2016/09/16 21:13:48, cco3 wrote: > On 2016/09/16 20:28:19, cco3 wrote: > > LGTM > > Please update as discussed in person. Updated
https://codereview.chromium.org/2330253002/diff/60001/chrome/android/java/src... File chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PwCollection.java (right): https://codereview.chromium.org/2330253002/diff/60001/chrome/android/java/src... chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PwCollection.java:8: * A physical web pair represents a UrlInfo and its corresponding PwsResult. comment needs updating https://codereview.chromium.org/2330253002/diff/60001/chrome/android/java/src... chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PwCollection.java:11: public final UrlInfo[] mUrlInfos; if it's public, don't use the m prefix https://codereview.chromium.org/2330253002/diff/60001/chrome/android/java/src... File chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java (right): https://codereview.chromium.org/2330253002/diff/60001/chrome/android/java/src... chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java:258: return new PwCollection(getUrls().toArray(new UrlInfo[0]), this will only return urls that have pws results, right? I think we might want all nearby urls. https://codereview.chromium.org/2330253002/diff/60001/chrome/android/java/src... chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java:302: private List<PwsResult> getPwsResultList(Set<String> urls) { I think it'd be better just to put this code directly into getPwCollection...we can split it out later if there's a need.
https://codereview.chromium.org/2330253002/diff/60001/chrome/android/java/src... File chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PwCollection.java (right): https://codereview.chromium.org/2330253002/diff/60001/chrome/android/java/src... chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PwCollection.java:8: * A physical web pair represents a UrlInfo and its corresponding PwsResult. On 2016/09/17 00:08:01, cco3 wrote: > comment needs updating Done. https://codereview.chromium.org/2330253002/diff/60001/chrome/android/java/src... chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PwCollection.java:11: public final UrlInfo[] mUrlInfos; On 2016/09/17 00:08:01, cco3 wrote: > if it's public, don't use the m prefix Done. https://codereview.chromium.org/2330253002/diff/60001/chrome/android/java/src... File chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java (right): https://codereview.chromium.org/2330253002/diff/60001/chrome/android/java/src... chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java:258: return new PwCollection(getUrls().toArray(new UrlInfo[0]), On 2016/09/17 00:08:01, cco3 wrote: > this will only return urls that have pws results, right? I think we might want > all nearby urls. Done. https://codereview.chromium.org/2330253002/diff/60001/chrome/android/java/src... chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java:302: private List<PwsResult> getPwsResultList(Set<String> urls) { On 2016/09/17 00:08:01, cco3 wrote: > I think it'd be better just to put this code directly into getPwCollection...we > can split it out later if there's a need. Done.
LGTM
cco3@chromium.org changed reviewers: + dfalcantara@chromium.org
lgtm
The CQ bit was checked by hayesjordan@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add access to Physical Web Service results To allow access to Physical Web data, the URL info and Physical Web Service data needs to be paired together. The pairing gives all relevant information for a scanned URL. BUG=636490 ========== to ========== Add access to Physical Web Service results To allow access to Physical Web data, the URL info and Physical Web Service data needs to be paired together. The pairing gives all relevant information for a scanned URL. BUG=636490 ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== Add access to Physical Web Service results To allow access to Physical Web data, the URL info and Physical Web Service data needs to be paired together. The pairing gives all relevant information for a scanned URL. BUG=636490 ========== to ========== Add access to Physical Web Service results To allow access to Physical Web data, the URL info and Physical Web Service data needs to be paired together. The pairing gives all relevant information for a scanned URL. BUG=636490 Committed: https://crrev.com/576c1dde62f1bc26e4366d50b32f76a636a1dbbd Cr-Commit-Position: refs/heads/master@{#419531} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/576c1dde62f1bc26e4366d50b32f76a636a1dbbd Cr-Commit-Position: refs/heads/master@{#419531}
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:80001) has been created in https://codereview.chromium.org/2356553002/ by dimich@chromium.org. The reason for reverting is: Broke build (compile): https://build.chromium.org/p/chromium.linux/builders/Android%20Clang%20Builde... ******************************************************************************** FindBugs run via: java -classpath /mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/third_party/findbugs/lib/findbugs.jar: -Xmx768m -Dfindbugs.home="/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/third_party/findbugs" -jar /mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/third_party/findbugs/lib/findbugs.jar -textui -sortByClass -pluginList /mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/tools/android/findbugs_plugin/lib/chromiumPlugin.jar -xml:withMessages -auxclasspath /mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/third_party/android_tools/sdk/platforms/android-23/android.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/base/base_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/chrome/android/webapk/libs/client/client_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/chrome/android/webapk/libs/common/common_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/chrome/android/webapk/libs/runtime_library/webapk_service_aidl_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/safe_json/android/safe_json_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/spellcheck/browser/android/java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/variations/android/variations_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/web_contents_delegate_android/web_contents_delegate_android_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/web_restrictions/web_restrictions_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/content/public/android/content_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/device/geolocation/geolocation_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/media/base/android/media_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/media/capture/content/android/screen_capture_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/media/capture/video/android/capture_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/media/midi/midi_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/mojo/public/java/bindings.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/mojo/public/java/system.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/net/android/net_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/printing/printing_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/WebKit/public/android_mojo_bindings_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/WebKit/public/blink_headers_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/android_data_chart/android_data_chart_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/android_media/android_media_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/android_protobuf/protobuf_nano_javalib.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/android_swipe_refresh/android_swipe_refresh_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/android_tools/android_gcm_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/android_tools/android_support_annotations_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/android_tools/android_support_design_java__classes.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/android_tools/android_support_v13_java__classes.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/android_tools/android_support_v13_java__subjar_internal_impl_24.1.1.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/android_tools/android_support_v4_java__classes.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/android_tools/android_support_v4_java__subjar_internal_impl_24.1.1.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/android_tools/android_support_v7_appcompat_java_internal__classes.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/android_tools/android_support_vector_drawable_java__classes.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/android_tools/android_support_v7_mediarouter_java__classes.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/android_tools/android_support_v7_mediarouter_java__subjar_internal_impl_24.1.1.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/android_tools/android_support_v7_recyclerview_java__classes.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/cacheinvalidation/cacheinvalidation_javalib.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/cacheinvalidation/cacheinvalidation_proto_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/custom_tabs_client/custom_tabs_support_lib.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/gif_player/gif_player_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/jsr-305/jsr_305_javalib.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/leakcanary/leakcanary_noop_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/ui/android/ui_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/url/mojo/url_mojom_gurl_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/third_party/android_tools/google_play_services_default_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/chrome/android/document_tab_model_info_proto_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/blimp/client/public/public_headers_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/blimp/client/core/dummy_core_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/bookmarks/common/android/bookmarks_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/dom_distiller/content/browser/android/dom_distiller_content_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/dom_distiller/core/android/dom_distiller_core_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/gcm_driver/android/gcm_driver_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/gcm_driver/instance_id/android/instance_id_driver_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/invalidation/impl/java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/location/android/location_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/navigation_interception/android/navigation_interception_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/ntp_tiles/android/ntp_tiles_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/policy/android/policy_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/precache/android/precache_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/safe_json/android/safe_json_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/signin/core/browser/android/java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/sync/android/sync_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/url_formatter/android/url_formatter_java.jar:/mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/components/web_contents_delegate_android/web_contents_delegate_android_java.jar -exclude /mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/build/android/findbugs_filter/findbugs_exclude.xml -output gen/chrome/android/chrome_java__findbugs/result.xml /mnt/data/b/c/b/Android_Clang_Builder__dbg_/src/out/Debug/lib.java/chrome/android/chrome_java.jar FindBugs reported the following issues: EI_EXPOSE_REP2: May expose internal representation by incorporating reference to mutable object In class org.chromium.chrome.browser.physicalweb.PwCollection In method new org.chromium.chrome.browser.physicalweb.PwCollection(UrlInfo[], PwsResult[]) Field org.chromium.chrome.browser.physicalweb.PwCollection.urlInfos At PwCollection.java:[line 20] EI_EXPOSE_REP2: May expose internal representation by incorporating reference to mutable object In class org.chromium.chrome.browser.physicalweb.PwCollection In method new org.chromium.chrome.browser.physicalweb.PwCollection(UrlInfo[], PwsResult[]) Field org.chromium.chrome.browser.physicalweb.PwCollection.pwsResults At PwCollection.java:[line 21] ******************************************************************************** .
Message was sent while issue was closed.
Description was changed from ========== Add access to Physical Web Service results To allow access to Physical Web data, the URL info and Physical Web Service data needs to be paired together. The pairing gives all relevant information for a scanned URL. BUG=636490 Committed: https://crrev.com/576c1dde62f1bc26e4366d50b32f76a636a1dbbd Cr-Commit-Position: refs/heads/master@{#419531} ========== to ========== Add access to Physical Web Service results To allow access to Physical Web data, the URL info and Physical Web Service data needs to be paired together. The pairing gives all relevant information for a scanned URL. BUG=636490 Committed: https://crrev.com/576c1dde62f1bc26e4366d50b32f76a636a1dbbd Cr-Commit-Position: refs/heads/master@{#419531} ==========
LGTM
The CQ bit was checked by cco3@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dfalcantara@chromium.org Link to the patchset: https://codereview.chromium.org/2330253002/#ps100001 (title: "Fix find bugs errors")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add access to Physical Web Service results To allow access to Physical Web data, the URL info and Physical Web Service data needs to be paired together. The pairing gives all relevant information for a scanned URL. BUG=636490 Committed: https://crrev.com/576c1dde62f1bc26e4366d50b32f76a636a1dbbd Cr-Commit-Position: refs/heads/master@{#419531} ========== to ========== Add access to Physical Web Service results To allow access to Physical Web data, the URL info and Physical Web Service data needs to be paired together. The pairing gives all relevant information for a scanned URL. BUG=636490 Committed: https://crrev.com/576c1dde62f1bc26e4366d50b32f76a636a1dbbd Cr-Commit-Position: refs/heads/master@{#419531} ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== Add access to Physical Web Service results To allow access to Physical Web data, the URL info and Physical Web Service data needs to be paired together. The pairing gives all relevant information for a scanned URL. BUG=636490 Committed: https://crrev.com/576c1dde62f1bc26e4366d50b32f76a636a1dbbd Cr-Commit-Position: refs/heads/master@{#419531} ========== to ========== Add access to Physical Web Service results To allow access to Physical Web data, the URL info and Physical Web Service data needs to be paired together. The pairing gives all relevant information for a scanned URL. BUG=636490 Committed: https://crrev.com/576c1dde62f1bc26e4366d50b32f76a636a1dbbd Committed: https://crrev.com/394cd0ae7e135631c6fdb2b41ad651edd65d57b5 Cr-Original-Commit-Position: refs/heads/master@{#419531} Cr-Commit-Position: refs/heads/master@{#419603} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/394cd0ae7e135631c6fdb2b41ad651edd65d57b5 Cr-Commit-Position: refs/heads/master@{#419603} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
