Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 2330223002: Remove buttons from internal page info bubble. (Closed)

Created:
4 years, 3 months ago by lgarron
Modified:
4 years, 3 months ago
Reviewers:
felt
CC:
chromium-reviews, markusheintz_, msramek+watch_chromium.org, raymes+watch_chromium.org, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove buttons from internal page info bubble. BUG=645855 Committed: https://crrev.com/9f7ed2e5171e67e2220ae844b06a5e8736fa38b5 Cr-Commit-Position: refs/heads/master@{#418236}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/ui/views/website_settings/website_settings_popup_view.cc View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
lgarron
felt@, could you review? I misunderstood the purpose of the GetDialogButtons() override, and accidentally took ...
4 years, 3 months ago (2016-09-12 22:07:06 UTC) #2
felt
lgtm
4 years, 3 months ago (2016-09-13 13:27:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2330223002/1
4 years, 3 months ago (2016-09-13 13:27:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-13 14:16:48 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 14:19:37 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9f7ed2e5171e67e2220ae844b06a5e8736fa38b5
Cr-Commit-Position: refs/heads/master@{#418236}

Powered by Google App Engine
This is Rietveld 408576698