Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2655)

Side by Side Diff: third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp

Issue 2330193002: ImageCapture: s/hasExposureMode/hasFillLightMode/ typo bug (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/imagecapture/ImageCapture.h" 5 #include "modules/imagecapture/ImageCapture.h"
6 6
7 #include "bindings/core/v8/CallbackPromiseAdapter.h" 7 #include "bindings/core/v8/CallbackPromiseAdapter.h"
8 #include "bindings/core/v8/ScriptPromiseResolver.h" 8 #include "bindings/core/v8/ScriptPromiseResolver.h"
9 #include "core/dom/DOMException.h" 9 #include "core/dom/DOMException.h"
10 #include "core/dom/ExceptionCode.h" 10 #include "core/dom/ExceptionCode.h"
(...skipping 148 matching lines...) Expand 10 before | Expand all | Expand 10 after
159 settings->exposure_compensation = photoSettings.exposureCompensation(); 159 settings->exposure_compensation = photoSettings.exposureCompensation();
160 settings->has_white_balance_mode = photoSettings.hasWhiteBalanceMode(); 160 settings->has_white_balance_mode = photoSettings.hasWhiteBalanceMode();
161 if (settings->has_white_balance_mode) 161 if (settings->has_white_balance_mode)
162 settings->white_balance_mode = parseMeteringMode(photoSettings.whiteBala nceMode()); 162 settings->white_balance_mode = parseMeteringMode(photoSettings.whiteBala nceMode());
163 settings->has_iso = photoSettings.hasIso(); 163 settings->has_iso = photoSettings.hasIso();
164 if (settings->has_iso) 164 if (settings->has_iso)
165 settings->iso = photoSettings.iso(); 165 settings->iso = photoSettings.iso();
166 settings->has_red_eye_reduction = photoSettings.hasRedEyeReduction(); 166 settings->has_red_eye_reduction = photoSettings.hasRedEyeReduction();
167 if (settings->has_red_eye_reduction) 167 if (settings->has_red_eye_reduction)
168 settings->red_eye_reduction = photoSettings.redEyeReduction(); 168 settings->red_eye_reduction = photoSettings.redEyeReduction();
169 settings->has_fill_light_mode = photoSettings.hasExposureMode(); 169 settings->has_fill_light_mode = photoSettings.hasFillLightMode();
170 if (settings->has_fill_light_mode) 170 if (settings->has_fill_light_mode)
171 settings->fill_light_mode = parseFillLightMode(photoSettings.fillLightMo de()); 171 settings->fill_light_mode = parseFillLightMode(photoSettings.fillLightMo de());
172 if (photoSettings.hasPointsOfInterest()) { 172 if (photoSettings.hasPointsOfInterest()) {
173 for (const auto& point : photoSettings.pointsOfInterest()) { 173 for (const auto& point : photoSettings.pointsOfInterest()) {
174 auto mojoPoint = media::mojom::blink::Point2D::New(); 174 auto mojoPoint = media::mojom::blink::Point2D::New();
175 mojoPoint->x = point.x(); 175 mojoPoint->x = point.x();
176 mojoPoint->y = point.y(); 176 mojoPoint->y = point.y();
177 settings->points_of_interest.append(std::move(mojoPoint)); 177 settings->points_of_interest.append(std::move(mojoPoint));
178 } 178 }
179 } 179 }
(...skipping 132 matching lines...) Expand 10 before | Expand all | Expand 10 after
312 312
313 DEFINE_TRACE(ImageCapture) 313 DEFINE_TRACE(ImageCapture)
314 { 314 {
315 visitor->trace(m_streamTrack); 315 visitor->trace(m_streamTrack);
316 visitor->trace(m_serviceRequests); 316 visitor->trace(m_serviceRequests);
317 EventTargetWithInlineData::trace(visitor); 317 EventTargetWithInlineData::trace(visitor);
318 ContextLifecycleObserver::trace(visitor); 318 ContextLifecycleObserver::trace(visitor);
319 } 319 }
320 320
321 } // namespace blink 321 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698