Adding target to build SwiftShader

Adding target to build SwiftShader

Added the swiftshader target to BUILD.gn's deps in order to enable building SwiftShader using 'ninja -C out/Default swiftshader' or similar command. The 'swiftshader' target already existed in third_party/swiftshader/BUILD.gn, but was unaccessible due to not being referenced in any other BUILD.gn files. Note that SwiftShader does not automatically build with Chromium.

BUG=630728
Committed: https://crrev.com/72ce608cb69854a0029f019e67ddf1509c274f0a
Cr-Commit-Position: refs/heads/master@{#418934}

[sugoi1, 2016-09-12 20:30:45]

The CQ bit was checked by sugoi@chromium.org to run a CQ dry run

[sugoi1, 2016-09-12 20:30:57]

The CQ bit was unchecked by sugoi@chromium.org

[sugoi, 2016-09-13 01:05:47]

The CQ bit was checked by sugoi@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 01:06:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 03:21:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 03:21:50]

Dry run: This issue passed the CQ dry run.

[sugoi1, 2016-09-14 21:14:42]

Description was changed from

==========
Adding target to build SwiftShader

Added the swiftshader target to BUILD.gn's deps in order to enable building
SwiftShader using 'ninja -C out/Default swiftshader' or similar command. The
'swiftshader' target already existed in third_party/swiftshader/BUILD.gn, but
was unaccessible due to not being referenced in any other BUILD.gn files. Note
that SwiftShader does not automatically build with Chromium.

BUG=630728
==========

to

==========
Adding target to build SwiftShader

Added the swiftshader target to BUILD.gn's deps in order to enable building
SwiftShader using 'ninja -C out/Default swiftshader' or similar command. The
'swiftshader' target already existed in third_party/swiftshader/BUILD.gn, but
was unaccessible due to not being referenced in any other BUILD.gn files. Note
that SwiftShader does not automatically build with Chromium.

BUG=630728
==========

[sugoi1, 2016-09-14 21:14:42]

sugoi@chromium.org changed reviewers:
+ thakis@chromium.org

[sugoi1, 2016-09-14 21:16:43]

Ok, let's try this again, I landed the new version of SwiftShader in the DEPS
file here:

https://codereview.chromium.org/2341863002/

The warnings which were causing the compilation to fail should be fixed.

If this cl lands and sticks, I'll try adding Mac compilation, which should also
work with the latest SwiftShader version.

[sugoi1, 2016-09-15 14:15:07]

The CQ bit was checked by sugoi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 14:15:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 16:05:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 16:05:13]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Nico, 2016-09-15 18:50:32]

lgtm

[sugoi1, 2016-09-15 18:53:05]

The CQ bit was checked by sugoi@chromium.org

[commit-bot: I haz the power, 2016-09-15 18:53:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 19:46:19]

Description was changed from

==========
Adding target to build SwiftShader

Added the swiftshader target to BUILD.gn's deps in order to enable building
SwiftShader using 'ninja -C out/Default swiftshader' or similar command. The
'swiftshader' target already existed in third_party/swiftshader/BUILD.gn, but
was unaccessible due to not being referenced in any other BUILD.gn files. Note
that SwiftShader does not automatically build with Chromium.

BUG=630728
==========

to

==========
Adding target to build SwiftShader

Added the swiftshader target to BUILD.gn's deps in order to enable building
SwiftShader using 'ninja -C out/Default swiftshader' or similar command. The
'swiftshader' target already existed in third_party/swiftshader/BUILD.gn, but
was unaccessible due to not being referenced in any other BUILD.gn files. Note
that SwiftShader does not automatically build with Chromium.

BUG=630728
==========

[commit-bot: I haz the power, 2016-09-15 19:46:20]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-15 19:47:57]

Description was changed from

==========
Adding target to build SwiftShader

Added the swiftshader target to BUILD.gn's deps in order to enable building
SwiftShader using 'ninja -C out/Default swiftshader' or similar command. The
'swiftshader' target already existed in third_party/swiftshader/BUILD.gn, but
was unaccessible due to not being referenced in any other BUILD.gn files. Note
that SwiftShader does not automatically build with Chromium.

BUG=630728
==========

to

==========
Adding target to build SwiftShader

Added the swiftshader target to BUILD.gn's deps in order to enable building
SwiftShader using 'ninja -C out/Default swiftshader' or similar command. The
'swiftshader' target already existed in third_party/swiftshader/BUILD.gn, but
was unaccessible due to not being referenced in any other BUILD.gn files. Note
that SwiftShader does not automatically build with Chromium.

BUG=630728

Committed: https://crrev.com/72ce608cb69854a0029f019e67ddf1509c274f0a
Cr-Commit-Position: refs/heads/master@{#418934}
==========

[commit-bot: I haz the power, 2016-09-15 19:47:59]

Patchset 4 (id:??) landed as
https://crrev.com/72ce608cb69854a0029f019e67ddf1509c274f0a
Cr-Commit-Position: refs/heads/master@{#418934}

[Nico, 2016-09-15 22:14:19]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2349473003/ by thakis@chromium.org.

The reason for reverting is: This seems to not build in our sysroot:
https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinuxASan/builds/5....

[sugoi, 2016-09-16 00:24:17]

On 2016/09/15 22:14:19, Nico wrote:
> A revert of this CL (patchset #4 id:60001) has been created in
> https://codereview.chromium.org/2349473003/ by mailto:thakis@chromium.org.
> 
> The reason for reverting is: This seems to not build in our sysroot:
>
https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinuxASan/builds/5....

Thanks, will try again tomorrow. I wish the commit queue bots were more
representative of the actual build bots, this is the second time this happens...