[layoutng] Better handling of border and padding

[layoutng] Better handling of border and padding

This makes a few changes to the border/padding handling:
- Cache the computed value in a member variable instead of
  recomputing it for each child
- Makes sure to add block_end border and padding to the box size
- Takes border and padding into account for overflow size,
  and also for the constraint space size
- Remove functions that duplicate functionality from
  computeBorder/computePadding

BUG=635619
Committed: https://crrev.com/f714d2bd4450811bae2c849b075344eb31814cd6
Cr-Commit-Position: refs/heads/master@{#418368}

[mstensho (USE GERRIT), 2016-09-12 20:05:49]

mstensho@opera.com changed reviewers:
+ mstensho@opera.com

[mstensho (USE GERRIT), 2016-09-12 20:05:51]

https://codereview.chromium.org/2330153002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc
(right):

https://codereview.chromium.org/2330153002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc:52:
NGLogicalSize(inline_size - border_and_padding_.inline_start,
I may lack some understanding of how this thing works, but here goes: Why
subtract only one side? What about inline end and block end?

[cbiesinger, 2016-09-13 18:04:54]

https://codereview.chromium.org/2330153002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc
(right):

https://codereview.chromium.org/2330153002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc:52:
NGLogicalSize(inline_size - border_and_padding_.inline_start,
On 2016/09/12 20:05:50, mstensho wrote:
> I may lack some understanding of how this thing works, but here goes: Why
> subtract only one side? What about inline end and block end?

Great point! That should be changed, thanks.

[cbiesinger, 2016-09-13 19:30:34]

Description was changed from

==========
[layoutng] Correct padding

BUG=
==========

to

==========
[layoutng] Better handling of border and padding

This makes a few changes to the border/padding handling:
- Cache the computed value in a member variable instead of
  recomputing it for each child
- Makes sure to add block_end border and padding to the box size
- Takes border and padding into account for overflow size,
  and also for the constraint space size
- Remove functions that duplicate functionality from
  computeBorder/computePadding

BUG=635619
==========

[cbiesinger, 2016-09-13 19:31:53]

cbiesinger@chromium.org changed reviewers:
+ eae@chromium.org, ikilpatrick@chromium.org

[cbiesinger, 2016-09-13 19:31:54]

I was going to write a test for percentage handling with border and padding, but
Morten points out in https://codereview.chromium.org/2334873002/ that the code
for that is broken right now, so that'll have to wait.

[cbiesinger, 2016-09-13 19:32:23]

Er, also, this is rebased to trunk -- please take a look!

[mstensho (USE GERRIT), 2016-09-13 19:45:19]

lgtm without the test change.

https://codereview.chromium.org/2330153002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc
(right):

https://codereview.chromium.org/2330153002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc:196:
//   #div2 { padding:5px 6px 7px 8px; }
Why this change? Is it even going to pass?

[cbiesinger, 2016-09-13 19:47:00]

The CQ bit was checked by cbiesinger@chromium.org

[cbiesinger, 2016-09-13 19:47:00]

The patchset sent to the CQ was uploaded after l-g-t-m from mstensho@opera.com
Link to the patchset: https://codereview.chromium.org/2330153002/#ps40001
(title: "undo comment change")

[cbiesinger, 2016-09-13 19:47:03]

https://codereview.chromium.org/2330153002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc
(right):

https://codereview.chromium.org/2330153002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc:196:
//   #div2 { padding:5px 6px 7px 8px; }
On 2016/09/13 19:45:19, mstensho wrote:
> Why this change? Is it even going to pass?

Whoops, I misread the code :( Reverted this change.

[commit-bot: I haz the power, 2016-09-13 19:47:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 21:06:32]

Description was changed from

==========
[layoutng] Better handling of border and padding

This makes a few changes to the border/padding handling:
- Cache the computed value in a member variable instead of
  recomputing it for each child
- Makes sure to add block_end border and padding to the box size
- Takes border and padding into account for overflow size,
  and also for the constraint space size
- Remove functions that duplicate functionality from
  computeBorder/computePadding

BUG=635619
==========

to

==========
[layoutng] Better handling of border and padding

This makes a few changes to the border/padding handling:
- Cache the computed value in a member variable instead of
  recomputing it for each child
- Makes sure to add block_end border and padding to the box size
- Takes border and padding into account for overflow size,
  and also for the constraint space size
- Remove functions that duplicate functionality from
  computeBorder/computePadding

BUG=635619
==========

[commit-bot: I haz the power, 2016-09-13 21:06:34]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-13 21:07:50]

Description was changed from

==========
[layoutng] Better handling of border and padding

This makes a few changes to the border/padding handling:
- Cache the computed value in a member variable instead of
  recomputing it for each child
- Makes sure to add block_end border and padding to the box size
- Takes border and padding into account for overflow size,
  and also for the constraint space size
- Remove functions that duplicate functionality from
  computeBorder/computePadding

BUG=635619
==========

to

==========
[layoutng] Better handling of border and padding

This makes a few changes to the border/padding handling:
- Cache the computed value in a member variable instead of
  recomputing it for each child
- Makes sure to add block_end border and padding to the box size
- Takes border and padding into account for overflow size,
  and also for the constraint space size
- Remove functions that duplicate functionality from
  computeBorder/computePadding

BUG=635619

Committed: https://crrev.com/f714d2bd4450811bae2c849b075344eb31814cd6
Cr-Commit-Position: refs/heads/master@{#418368}
==========

[commit-bot: I haz the power, 2016-09-13 21:07:51]

Patchset 3 (id:??) landed as
https://crrev.com/f714d2bd4450811bae2c849b075344eb31814cd6
Cr-Commit-Position: refs/heads/master@{#418368}

[eae, 2016-09-15 09:25:20]

LGTM (post facto)