Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: scripts/slave/recipes/chromium.py

Issue 2330133002: Updating the SwarmingIsolatedScriptTest to upload chartjson results to the (Closed)
Patch Set: Fixing presubmit issues Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/chromium.py
diff --git a/scripts/slave/recipes/chromium.py b/scripts/slave/recipes/chromium.py
index 3b5d1c22c385e2782d10a67ada000abc83fc84db..dc683f220d496a3c871326f9137982ef38c89fc5 100644
--- a/scripts/slave/recipes/chromium.py
+++ b/scripts/slave/recipes/chromium.py
@@ -466,10 +466,18 @@ def GenTests(api):
api.test('dynamic_swarmed_sharded_passed_isolated_script_test') +
api.properties.generic(mastername='chromium.linux',
buildername='Linux Tests',
- parent_buildername='Linux Builder') +
- api.properties(swarm_hashes={
- 'telemetry_gpu_unittests': 'eeeeeeeeeeeeeeeeeeeeeeeeeeeeee',
- }) +
+ parent_buildername='Linux Builder',
+ got_revision_cp='refs/heads/master@{#291141}',
+ buildnumber='1234',
+ version='v23523',
+ git_revision='asdfawe2342',
+ got_webrtc_revision='asdfas',
+ got_v8_revision='asdfadsfa4e3w') +
+
+ api.properties(
+ swarm_hashes={
+ 'telemetry_gpu_unittests': 'eeeeeeeeeeeeeeeeeeeeeeeeeeeeee'
+ }, **{'perf-id': 'testid', 'results-url': 'http://test-results-url'}) +
api.platform('linux', 64) +
api.override_step_data(
'read test spec (chromium.linux.json)',
@@ -636,10 +644,47 @@ def GenTests(api):
)
yield (
+ api.test('dynamic_swarmed_sharded_isolated_chartjson_test_disabled') +
+ api.properties.generic(mastername='chromium.linux',
+ buildername='Linux Tests',
+ parent_buildername='Linux Builder',
+ got_revision_cp='refs/heads/master@{#291141}') +
+ api.properties(swarm_hashes={
+ 'telemetry_gpu_unittests': 'eeeeeeeeeeeeeeeeeeeeeeeeeeeeee',
+ }) +
+ api.platform('linux', 64) +
+ api.override_step_data(
+ 'read test spec (chromium.linux.json)',
+ api.json.output({
+ 'Linux Tests': {
+ 'isolated_scripts': [
+ {
+ 'isolate_name': 'telemetry_gpu_unittests',
+ 'name': 'telemetry_gpu_unittests',
+ 'swarming': {
+ 'can_use_on_swarming_builders': True,
+ 'shards': 2,
+ },
+ },
+ ],
+ },
+ })
+ ) +
+ api.override_step_data('telemetry_gpu_unittests on Ubuntu-12.04',
+ api.test_utils.canned_isolated_script_output(
+ passing=True, is_win=False, swarming=True,
+ shards=2, isolated_script_passing=True, valid=True,
+ output_chartjson=True, benchmark_enabled=False),
+ retcode=0)
+ )
+
+ yield (
api.test('dynamic_swarmed_sharded_isolated_chartjson_test_missing_shard') +
api.properties.generic(mastername='chromium.linux',
buildername='Linux Tests',
- parent_buildername='Linux Builder') +
+ parent_buildername='Linux Builder',
+ got_revision_cp='refs/heads/master@{#291141}'
+ ) +
api.properties(swarm_hashes={
'telemetry_gpu_unittests': 'eeeeeeeeeeeeeeeeeeeeeeeeeeeeee',
}) +

Powered by Google App Engine
This is Rietveld 408576698