Updating the SwarmingIsolatedScriptTest to upload chartjson results to the

scripts/slave/recipe_modules/chromium_tests/steps.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import datetime
 import re
 import string
 
+from slave import slave_utils
+from slave import results_dashboard
 
 class Test(object):
   """
   Base class for tests that can be retried after deapplying a previously
   applied patch.
   """
 
   def __init__(self):
     super(Test, self).__init__()
     self._test_runs = {}
@@ skipping 1056 matching lines @@
 
   def validate_task_results(self, api, step_result):
     results = getattr(step_result, 'isolated_script_results', None) or {}
 
     try:
       failures = results['failures']
       valid = results['valid']
       if not failures and step_result.retcode != 0:
         failures = ['%s (entire test suite)' % self.name]
         valid = False
+      if 'chartjson' in results and 'charts' in results['chartjson']:

[Ken Russell (switch to Gerrit), 2016/09/12 19:35:40]

Per comment on dependent CL https://codereview.chromium.org/2331993003/ : I
think that the chartjson results should be written to a separate file, by adding
another command line argument --isolated-script-chartjson-output similar to the
existing --isolated-script-test-output. It's known that we are going to need at
least one more output file format here for the flakiness dashboard, so instead
of overloading this simplified json format we should start enhancing the
interface between IsolatedScriptTest and recipes now.

[eyaich1, 2016/09/13 16:52:59]

Done.

+        # This is a swarmed benchmark, need to upload results to the dashboard
+        # Not sure if we still need to process the valid/failures since the
+        # output we need will be written by telemetry and the retcode should
+        # turn the test red or green
+        main_revision = \
+            GetMainRevision(api.properties, api.chromium.c.build_dir)
+        blink_revision = GetBlinkRevision(api.chromium.c.build_dir):
+        revisions = slave_utils.GetTelemetryRevisions(
+            api.properties, main_revision, blink_revision)
+        reference_build = 'reference' in self.name
+        stripped_test_name = self.name.replace('.reference', '')
+        dashboard_json = results_dashboard.MakeDashboardJsonV1(
+            results['chartjson'],
+            revisions, stripped_test_name, api.properties['perf-id'],
+            api.properties['buildername'], api.properties['buildnumber'],
+            None, reference_build)
+        if dashboard_json :
+          logging.debug(json.dumps(dashboard_json , indent=2))
+          results_dashboard.SendResults(
+            dashboard_json ,
+            api.properties['results-url'],
+            api.chromium.c.build_dir)
+        else:
+          print 'Error: No json output from telemetry.'
+          print '@@@STEP_FAILURE@@@'
+
+
     except (ValueError, KeyError) as e:
       step_result.presentation.logs['invalid_results_exc'] = [str(e)]
       valid = False
       failures = None
     if valid:
       step_result.presentation.step_text += api.test_utils.format_step_text([
         ['failures:', failures]
       ])
     return valid, failures
 
@@ skipping 650 matching lines @@
           args=args)
       api.gsutil.upload(
           temp_output_dir.join(
               '%s-android-chrome.json' % timestamp_string),
           'chromium-annotated-tests', 'android')
 
 GOMA_TESTS = [
   GTestTest('base_unittests'),
   GTestTest('content_unittests'),
 ]