Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 233013004: Version 3.25.28.12 (merged r20544, r20645, r20664, r20553) (Closed)

Created:
6 years, 8 months ago by Sven Panne
Modified:
6 years, 8 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Visibility:
Public.

Description

Version 3.25.28.12 (merged r20544, r20645, r20664, r20553) Fixed flooring division by -1 on ARM and MIPS. Do not use ranges after range analysis. x64: Make sure that the upper half of a 64bit register contains 0 for int32 values. BUG=360611, 361608, v8:3259 LOG=Y R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20668

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -83 lines) Patch
M src/arm/lithium-codegen-arm.cc View 1 chunk +13 lines, -11 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 chunk +17 lines, -11 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +15 lines, -11 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +19 lines, -17 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/assembler-x64.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/x64/assembler-x64.cc View 2 chunks +18 lines, -0 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 7 chunks +65 lines, -24 lines 0 comments Download
M src/x64/lithium-x64.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M test/cctest/test-disasm-x64.cc View 1 chunk +2 lines, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-361608.js View 1 chunk +11 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
6 years, 8 months ago (2014-04-11 07:26:19 UTC) #1
Benedikt Meurer
LGTM
6 years, 8 months ago (2014-04-11 07:26:57 UTC) #2
Sven Panne
6 years, 8 months ago (2014-04-11 07:27:44 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20668.

Powered by Google App Engine
This is Rietveld 408576698