Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Side by Side Diff: src/globals.h

Issue 23301006: Revert "Add FINAL and OVERRIDE macros for C++11 final/override." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ast.h ('k') | src/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 312 matching lines...) Expand 10 before | Expand all | Expand 10 after
323 323
324 324
325 // FUNCTION_CAST<F>(addr) casts an address into a function 325 // FUNCTION_CAST<F>(addr) casts an address into a function
326 // of type F. Used to invoke generated code from within C. 326 // of type F. Used to invoke generated code from within C.
327 template <typename F> 327 template <typename F>
328 F FUNCTION_CAST(Address addr) { 328 F FUNCTION_CAST(Address addr) {
329 return reinterpret_cast<F>(reinterpret_cast<intptr_t>(addr)); 329 return reinterpret_cast<F>(reinterpret_cast<intptr_t>(addr));
330 } 330 }
331 331
332 332
333 // Compiler feature detection.
334 #if defined(__clang__)
335
336 // Compatibility with older clang versions.
337 # ifndef __has_extension
338 # define __has_extension __has_feature
339 # endif
340
341 # if __has_extension(cxx_override_control)
342 # define V8_HAVE_CXX11_FINAL
343 # define V8_HAVE_CXX11_OVERRIDE
344 # endif
345
346 #elif defined(__GNUC__)
347
348 // g++ requires -std=c++0x or -std=gnu++0x to support C++11 functionality
349 // without warnings (functionality used by the macros below). These modes
350 // are detectable by checking whether __GXX_EXPERIMENTAL_CXX0X__ is defined or,
351 // more standardly, by checking whether __cplusplus has a C++11 or greater
352 // value. Current versions of g++ do not correctly set __cplusplus, so we check
353 // both for forward compatibility.
354 # if defined(__GXX_EXPERIMENTAL_CXX0X__) || __cplusplus >= 201103L
355 # if __GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 7)
356 # define V8_HAVE_CXX11_OVERRIDE
357 # define V8_HAVE_CXX11_FINAL
358 # endif
359 # else
360 // '__final' is a non-C++11 GCC synonym for 'final', per GCC r176655.
361 # if __GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 7)
362 # define V8_HAVE_GXX_FINAL
363 # endif
364 # endif
365
366 #elif defined(_MSC_VER)
367
368 # if _MSC_VER >= 1400
369 # define V8_HAVE_CXX11_OVERRIDE
370 // MSVC currently spells "final" as "sealed".
371 # define V8_HAVE_MSVC_SEALED
372 # endif
373
374 #endif
375
376
377 #if __cplusplus >= 201103L 333 #if __cplusplus >= 201103L
378 #define DISALLOW_BY_DELETE = delete 334 #define DISALLOW_BY_DELETE = delete
379 #else 335 #else
380 #define DISALLOW_BY_DELETE 336 #define DISALLOW_BY_DELETE
381 #endif 337 #endif
382 338
383 339
384 // A macro to disallow the evil copy constructor and operator= functions 340 // A macro to disallow the evil copy constructor and operator= functions
385 // This should be used in the private: declarations for a class 341 // This should be used in the private: declarations for a class
386 #define DISALLOW_COPY_AND_ASSIGN(TypeName) \ 342 #define DISALLOW_COPY_AND_ASSIGN(TypeName) \
(...skipping 25 matching lines...) Expand all
412 #endif 368 #endif
413 #elif defined(_MSC_VER) && !defined(DEBUG) 369 #elif defined(_MSC_VER) && !defined(DEBUG)
414 #define INLINE(header) __forceinline header 370 #define INLINE(header) __forceinline header
415 #define NO_INLINE(header) header 371 #define NO_INLINE(header) header
416 #else 372 #else
417 #define INLINE(header) inline header 373 #define INLINE(header) inline header
418 #define NO_INLINE(header) header 374 #define NO_INLINE(header) header
419 #endif 375 #endif
420 376
421 377
422 // Annotate a virtual method indicating it must be overriding a virtual
423 // method in the parent class.
424 // Use like:
425 // virtual void bar() OVERRIDE;
426 #if defined(V8_HAVE_CXX11_OVERRIDE)
427 #define OVERRIDE override
428 #else
429 #define OVERRIDE
430 #endif
431
432
433 // Annotate a virtual method indicating that subclasses must not override it,
434 // or annotate a class to indicate that it cannot be subclassed.
435 // Use like:
436 // class B FINAL : public A {};
437 // virtual void bar() FINAL;
438 #if defined(V8_HAVE_CXX11_FINAL)
439 #define FINAL final
440 #elif defined(V8_HAVE_GXX_FINAL)
441 #define FINAL __final
442 #elif defined(V8_HAVE_MSVC_SEALED)
443 #define FINAL sealed
444 #else
445 #define FINAL
446 #endif
447
448
449 #if defined(__GNUC__) && __GNUC__ >= 4 378 #if defined(__GNUC__) && __GNUC__ >= 4
450 #define MUST_USE_RESULT __attribute__ ((warn_unused_result)) 379 #define MUST_USE_RESULT __attribute__ ((warn_unused_result))
451 #else 380 #else
452 #define MUST_USE_RESULT 381 #define MUST_USE_RESULT
453 #endif 382 #endif
454 383
455 384
456 // Define DISABLE_ASAN macros. 385 // Define DISABLE_ASAN macros.
457 #if defined(__has_feature) 386 #if defined(__has_feature)
458 #if __has_feature(address_sanitizer) 387 #if __has_feature(address_sanitizer)
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
514 // the backend, so both modes are represented by the kStrictMode value. 443 // the backend, so both modes are represented by the kStrictMode value.
515 enum StrictModeFlag { 444 enum StrictModeFlag {
516 kNonStrictMode, 445 kNonStrictMode,
517 kStrictMode 446 kStrictMode
518 }; 447 };
519 448
520 449
521 } } // namespace v8::internal 450 } } // namespace v8::internal
522 451
523 #endif // V8_GLOBALS_H_ 452 #endif // V8_GLOBALS_H_
OLDNEW
« no previous file with comments | « src/ast.h ('k') | src/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698