Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2330093003: Fix adding displays in mustash. (Closed)

Created:
4 years, 3 months ago by kylechar
Modified:
4 years, 3 months ago
Reviewers:
msw, sky
CC:
chromium-reviews, rjkroege, sky
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix adding displays in mustash. This CL fixes two bugs that occured when adding displays after the initial display setup. The first bug is caused by Display::OnViewportMetricsChanged() getting called before the WindowManagerDisplayRoot for the display is created. ScreenMus receives a message that a display has been added before the WindowTreeClient was updated. When ash looked for the root window controller corresponding to the display it didn't exist yet. Fix by not calling OnDisplayUpdated() if the ui::ws::Display hasn't been initialized yet and explicitly call it after WindowManagerDisplayRoot(s) have been created. The second bug was not initializing the GPU channel for displays after the first display. BUG=641012 Committed: https://crrev.com/ff1f2f190b17b41e787f89f6825d6cc3bbd10bec Cr-Commit-Position: refs/heads/master@{#418242}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M services/ui/ws/display.cc View 2 chunks +3 lines, -1 line 0 comments Download
M services/ui/ws/display_manager.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
kylechar
4 years, 3 months ago (2016-09-12 17:35:08 UTC) #2
msw
lgtm
4 years, 3 months ago (2016-09-12 17:50:30 UTC) #3
sky
LGTM
4 years, 3 months ago (2016-09-12 20:06:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2330093003/1
4 years, 3 months ago (2016-09-13 13:38:11 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-13 14:37:03 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 14:39:06 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ff1f2f190b17b41e787f89f6825d6cc3bbd10bec
Cr-Commit-Position: refs/heads/master@{#418242}

Powered by Google App Engine
This is Rietveld 408576698