Avoid static initializers and global variables in 'pdfium_test'.

Avoid static initializers and global variables in 'pdfium_test'.

This CL aims to follow up on thestig's past-land feedback
receveid on https://codereview.chromium.org/2277063003/#msg15 .

In order to avoid static initializers and global data
declaration, CL adds a data struct named PDFiumTest_FPDF_FORMFILLINFO,
which has FPDF_FORMFILLINFO as the first struct member definition.
This allows the use of reinterpret_cast to/from
PDFiumTest_FPDF_FORMFILLINFO and PDF_FORMFILLINFO.

PDFiumTest_FPDF_FORMFILLINFO also two more struct members,
'loadedPages' and 'formHandle', which were previously global
variables.

Committed: https://pdfium.googlesource.com/pdfium/+/81d92f8ffc5e632ade8c507b8f2e34c5fe3ca902

[tonikitoo, 2016-09-12 15:05:09]

Description was changed from

==========
Avoid static initializers and global variables in 'pdfium_test'.

This CL aims to follow up on thestig's past-land feedback
receveid on https://codereview.chromium.org/2277063003/#msg15 .

In order to avoid static initializers and global data
declaration, CL adds a data struct named PDFiumTest_FPDF_FORMFILLINFO,
which has FPDF_FORMFILLINFO as the first struct member definition.
This allows the use of reinterpret_cast to/from
PDFiumTest_FPDF_FORMFILLINFO and PDF_FORMFILLINFO.

PDFiumTest_FPDF_FORMFILLINFO also two more struct members,
'loadedPages' and 'formHandle', which were previously global
variables.
==========

to

==========
Avoid static initializers and global variables in 'pdfium_test'.

This CL aims to follow up on thestig's past-land feedback
receveid on https://codereview.chromium.org/2277063003/#msg15 .

In order to avoid static initializers and global data
declaration, CL adds a data struct named PDFiumTest_FPDF_FORMFILLINFO,
which has FPDF_FORMFILLINFO as the first struct member definition.
This allows the use of reinterpret_cast to/from
PDFiumTest_FPDF_FORMFILLINFO and PDF_FORMFILLINFO.

PDFiumTest_FPDF_FORMFILLINFO also two more struct members,
'loadedPages' and 'formHandle', which were previously global
variables.
==========

[tonikitoo, 2016-09-12 15:05:09]

tonikitoo@igalia.com changed reviewers:
+ dsinclair@chromium.org, thestig@chromium.org, tsepez@chromium.org

[tonikitoo, 2016-09-12 15:07:08]

PTAL

[Tom Sepez, 2016-09-12 17:19:41]

https://codereview.chromium.org/2330043002/diff/1/samples/pdfium_test.cc
File samples/pdfium_test.cc (right):

https://codereview.chromium.org/2330043002/diff/1/samples/pdfium_test.cc#newc...
samples/pdfium_test.cc:70: typedef struct {
nit: In C++, we can avoid "typedef" adn just write:
 
struct PDFiumTest_FPDF_FORMFILLINFO {

https://codereview.chromium.org/2330043002/diff/1/samples/pdfium_test.cc#newc...
samples/pdfium_test.cc:82: static PDFiumTest_FPDF_FORMFILLINFO*
ToPDFiumTestFormFillInfo(
It might be cleaner if PDFiumTest_FPDF_FORMFILLINFO inherited from
FPDF_FORMFILLINFO, then we can static_cast<> in one direction, and just rely on
the compiler to automatically promote in the other direction.

[tonikitoo, 2016-09-12 23:41:55]

Comments addressed.

https://codereview.chromium.org/2330043002/diff/1/samples/pdfium_test.cc
File samples/pdfium_test.cc (right):

https://codereview.chromium.org/2330043002/diff/1/samples/pdfium_test.cc#newc...
samples/pdfium_test.cc:70: typedef struct {
On 2016/09/12 17:19:41, Tom Sepez wrote:
> nit: In C++, we can avoid "typedef" adn just write:
>  
> struct PDFiumTest_FPDF_FORMFILLINFO {

Done.

https://codereview.chromium.org/2330043002/diff/1/samples/pdfium_test.cc#newc...
samples/pdfium_test.cc:82: static PDFiumTest_FPDF_FORMFILLINFO*
ToPDFiumTestFormFillInfo(
On 2016/09/12 17:19:40, Tom Sepez wrote:
> It might be cleaner if PDFiumTest_FPDF_FORMFILLINFO inherited from
> FPDF_FORMFILLINFO, then we can static_cast<> in one direction, and just rely
on
> the compiler to automatically promote in the other direction.

Done.

[tonikitoo, 2016-09-20 02:59:03]

Friendly ping.

[dsinclair, 2016-09-21 17:25:13]

https://codereview.chromium.org/2330043002/diff/20001/samples/pdfium_test.cc
File samples/pdfium_test.cc (right):

https://codereview.chromium.org/2330043002/diff/20001/samples/pdfium_test.cc#...
samples/pdfium_test.cc:658: memset(&form_callbacks, '\0',
sizeof(platform_callbacks));
Shouldn't this be form_callbacks?

[tonikitoo, 2016-09-21 18:21:35]

https://codereview.chromium.org/2330043002/diff/20001/samples/pdfium_test.cc
File samples/pdfium_test.cc (right):

https://codereview.chromium.org/2330043002/diff/20001/samples/pdfium_test.cc#...
samples/pdfium_test.cc:658: memset(&form_callbacks, '\0',
sizeof(platform_callbacks));
On 2016/09/21 17:25:13, dsinclair wrote:
> Shouldn't this be form_callbacks?

You are right. After FPDF_FORMFILLINFO_PDFiumTest : FPDF_FORMFILLINFO
inheritance, memset stopped working for zero'ing out the object, and I played
locally with some variants.

In the I decided to initialize the object with " = {};" instead.

[Tom Sepez, 2016-09-21 18:52:59]

lgtm

[dsinclair, 2016-09-21 18:53:48]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-09-21 18:53:48]

lgtm

[commit-bot: I haz the power, 2016-09-21 18:53:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 19:44:59]

Description was changed from

==========
Avoid static initializers and global variables in 'pdfium_test'.

This CL aims to follow up on thestig's past-land feedback
receveid on https://codereview.chromium.org/2277063003/#msg15 .

In order to avoid static initializers and global data
declaration, CL adds a data struct named PDFiumTest_FPDF_FORMFILLINFO,
which has FPDF_FORMFILLINFO as the first struct member definition.
This allows the use of reinterpret_cast to/from
PDFiumTest_FPDF_FORMFILLINFO and PDF_FORMFILLINFO.

PDFiumTest_FPDF_FORMFILLINFO also two more struct members,
'loadedPages' and 'formHandle', which were previously global
variables.
==========

to

==========
Avoid static initializers and global variables in 'pdfium_test'.

This CL aims to follow up on thestig's past-land feedback
receveid on https://codereview.chromium.org/2277063003/#msg15 .

In order to avoid static initializers and global data
declaration, CL adds a data struct named PDFiumTest_FPDF_FORMFILLINFO,
which has FPDF_FORMFILLINFO as the first struct member definition.
This allows the use of reinterpret_cast to/from
PDFiumTest_FPDF_FORMFILLINFO and PDF_FORMFILLINFO.

PDFiumTest_FPDF_FORMFILLINFO also two more struct members,
'loadedPages' and 'formHandle', which were previously global
variables.

Committed:
https://pdfium.googlesource.com/pdfium/+/81d92f8ffc5e632ade8c507b8f2e34c5fe3c...
==========

[commit-bot: I haz the power, 2016-09-21 19:44:59]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/81d92f8ffc5e632ade8c507b8f2e34c5fe3c...