Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Issue 2330033002: Merge internal change: 132864057 (Closed)

Created:
4 years, 3 months ago by Fan Yang
Modified:
4 years, 3 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, Jana
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow server address change to mapped Ipv4 address. Protected by ENABLED FLAGS_quic_allow_server_address_change_for_mapped_ipv4. Merge internal change: 132864057 Committed: https://crrev.com/8a097bc50da1e61bee09894f3e89f452f83172a2 Cr-Commit-Position: refs/heads/master@{#417984}

Patch Set 1 #

Patch Set 2 : re-sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -4 lines) Patch
M net/quic/core/quic_connection.cc View 1 chunk +25 lines, -4 lines 0 comments Download
M net/quic/core/quic_connection_test.cc View 1 chunk +27 lines, -0 lines 0 comments Download
M net/quic/core/quic_flags_list.h View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (16 generated)
Fan Yang
4 years, 3 months ago (2016-09-12 14:36:16 UTC) #3
Ryan Hamilton
lgtm
4 years, 3 months ago (2016-09-12 16:35:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2330033002/1
4 years, 3 months ago (2016-09-12 16:39:45 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/294576)
4 years, 3 months ago (2016-09-12 16:42:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2330033002/20001
4 years, 3 months ago (2016-09-12 18:39:01 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-12 18:45:03 UTC) #21
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 18:46:36 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8a097bc50da1e61bee09894f3e89f452f83172a2
Cr-Commit-Position: refs/heads/master@{#417984}

Powered by Google App Engine
This is Rietveld 408576698