Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 233003003: Clean up the default gamma settings. (Closed)

Created:
6 years, 8 months ago by bungeman-skia
Modified:
6 years, 8 months ago
Reviewers:
djsollen, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Clean up the default gamma settings. This makes it a compile error to specify both SK_GAMMA_EXPONENT and SK_GAMMA_SRGB. It also ensures that SK_GAMMA_EXPONENT will be set consistently. R=djsollen@google.com, reed@google.com Committed: https://code.google.com/p/skia/source/detail?r=14143

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M include/core/SkDeviceProperties.h View 1 chunk +0 lines, -9 lines 0 comments Download
M include/core/SkPostConfig.h View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
bungeman-skia
This change will make the issue found with Android setting both of the gamma settings ...
6 years, 8 months ago (2014-04-10 16:03:03 UTC) #1
djsollen
lgtm. You will want to wait and land this patch after I land my CL ...
6 years, 8 months ago (2014-04-10 16:06:27 UTC) #2
reed1
lgtm
6 years, 8 months ago (2014-04-10 19:26:27 UTC) #3
bungeman-skia
6 years, 8 months ago (2014-04-10 22:26:48 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r14143 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698