Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2330003002: Add linux_chromium_headless_dbg trybot builder and slaves (Closed)

Created:
4 years, 3 months ago by perezju
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke, Sami
CC:
chromium-reviews, infra-reviews+build_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Add linux_chromium_headless_dbg trybot builder and slaves Add slaves and builder configuration for new linux_chromium_headless_dbg trybot. New slaves were provided at: crbug.com/633985 BUG=632008 Committed: https://chromium.googlesource.com/chromium/tools/build/+/4720403d60ca3522c66f873633c4f19b0a463508

Patch Set 1 #

Total comments: 2

Patch Set 2 : config headless slaves separately #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M masters/master.tryserver.chromium.linux/master.cfg View 1 chunk +8 lines, -0 lines 0 comments Download
M masters/master.tryserver.chromium.linux/slaves.cfg View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
perezju
Dirk, please have a careful look at my changes here. This is my first time ...
4 years, 3 months ago (2016-09-12 13:57:53 UTC) #2
perezju
https://codereview.chromium.org/2330003002/diff/1/masters/master.tryserver.chromium.linux/slaves.cfg File masters/master.tryserver.chromium.linux/slaves.cfg (right): https://codereview.chromium.org/2330003002/diff/1/masters/master.tryserver.chromium.linux/slaves.cfg#newcode119 masters/master.tryserver.chromium.linux/slaves.cfg:119: 'version': 'precise', I'm a bit confused about this bit ...
4 years, 3 months ago (2016-09-12 14:00:27 UTC) #3
Dirk Pranke
https://codereview.chromium.org/2330003002/diff/1/masters/master.tryserver.chromium.linux/slaves.cfg File masters/master.tryserver.chromium.linux/slaves.cfg (right): https://codereview.chromium.org/2330003002/diff/1/masters/master.tryserver.chromium.linux/slaves.cfg#newcode119 masters/master.tryserver.chromium.linux/slaves.cfg:119: 'version': 'precise', On 2016/09/12 14:00:27, perezju wrote: > I'm ...
4 years, 3 months ago (2016-09-12 18:45:20 UTC) #4
perezju
PTAL, hope this makes a bit more sense.
4 years, 3 months ago (2016-09-13 13:15:29 UTC) #5
Dirk Pranke
Yup, that should work. lgtm.
4 years, 3 months ago (2016-09-13 21:15:36 UTC) #6
perezju
Thanks! I think I would also need to land https://codereview.chromium.org/2336573002/ first? Could you help me ...
4 years, 3 months ago (2016-09-14 10:17:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2330003002/20001
4 years, 3 months ago (2016-09-15 10:25:45 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 10:29:45 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/4720403d60ca3522c66f...

Powered by Google App Engine
This is Rietveld 408576698