Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 2329983002: Reland "[heap] Fix a formatting bug in --trace-incremental-marking. (patchset #2 id:20001 of https:… (Closed)

Created:
4 years, 3 months ago by ulan
Modified:
4 years, 3 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "[heap] Fix a formatting bug in --trace-incremental-marking. (patchset #2 id:20001 of https://codereview.chromium.org/2324623004/ )" This reverts commit 6c2a217ef771b1d770cc223b9c4908715fe573d1. The performance regression in crbug.com/645411 was not caused by the original CL. TBR=mlippautz@chromium.org Committed: https://crrev.com/a26769629b0a9ad39240fa138958c914cf1b8dee Cr-Commit-Position: refs/heads/master@{#39353}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M src/heap/heap.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/isolate.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2329983002/1
4 years, 3 months ago (2016-09-12 12:38:19 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-12 13:03:57 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 13:04:35 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a26769629b0a9ad39240fa138958c914cf1b8dee
Cr-Commit-Position: refs/heads/master@{#39353}

Powered by Google App Engine
This is Rietveld 408576698